Gnus development mailing list
 help / color / mirror / Atom feed
* address parsing problem in latest CVS
@ 2006-09-07  3:28 Dave Goldberg
  2006-09-07  4:47 ` Katsumi Yamaoka
  0 siblings, 1 reply; 6+ messages in thread
From: Dave Goldberg @ 2006-09-07  3:28 UTC (permalink / raw)


I'm back from a couple week's vacation and at work did a CVS update
before getting into email with Gnus.  I've found that the patches from
9/1 with the following ChangeLog entry have resulted in broken
addresses being passed to smtpmail:

2006-09-01  Katsumi Yamaoka  <yamaoka@jpl.org>

        * gnus-art.el (gnus-decode-address-function): New variable.
        (article-decode-encoded-words): Use it to decode headers which are
        assumed to contain addresses.
        (gnus-mime-delete-part): Remove useless `or'.

        * gnus-sum.el (gnus-decode-encoded-address-function): New variable.
        (gnus-summary-from-or-to-or-newsgroups): Use it to decode To header.
        (gnus-nov-parse-line): Use it to decode From header.
        (gnus-get-newsgroup-headers): Ditto.
        (gnus-summary-enter-digest-group): Use it to decode `to-address'.

        * mail-parse.el (mail-decode-encoded-address-region): New alias.
        (mail-decode-encoded-address-string): New alias.

        * rfc2047.el (rfc2047-quote-special-characters-in-quoted-strings):
        New function.
        (rfc2047-encode-message-header, rfc2047-encode-region): Use it.
        (rfc2047-strip-backslashes-in-quoted-strings): New fnction.
        (rfc2047-decode-region): Use it; add optional argument `address-mime'.
        (rfc2047-decode-string): Ditto.
        (rfc2047-decode-address-region): New function.
        (rfc2047-decode-address-string): New function.

The symptom looks like this (addresses sanitized):

220 exchange.work.ORG Microsoft ESMTP MAIL Service, Version: 6.0.3790.1830 ready at  Wed, 6 Sep 2006 15:57:54 -0400 
EHLO my-PC.work.ORG.work.org
250-exchange.work.ORG Hello [10.0.0.73]
250-TURN
250-SIZE
250-ETRN
250-PIPELINING
250-DSN
250-ENHANCEDSTATUSCODES
250-8bitmime
250-BINARYMIME
250-CHUNKING
250-VRFY
250-X-EXPS GSSAPI NTLM LOGIN
250-X-EXPS=LOGIN
250-AUTH GSSAPI NTLM LOGIN
250-AUTH=LOGIN
250-X-LINK2STATE
250-XEXCH50
250 OK
MAIL FROM: <me@work.org> SIZE=3565
250 2.1.0 me@work.org....Sender OK
RCPT TO: <someone@yahoo.com>
250 2.1.5 someone@yahoo.com 
RCPT TO: <"\\_^_<someoneelse\\@work.org\\>\\")>
501 5.5.4 Invalid Address
QUIT
221 Closing connection. Good bye.

Process SMTP exited abnormally with code 256

The address in question is always the first on the CC line.  Most of
my addresses are of the form "Real Name" <user@whatever.com>.
Manually stripping the addresses is a workaround but became too
frustrating so I simply backed out to the immediately previous
versions of rfc2047.el, gnus-sum.el, gnus-art.el and mail-parse.el for
now.  Because I'm just back I did not have time to investigate any
further than that but am willing to do so after I get caught up a bit
at work.   I am more than happy to test patches too :-)

Thanks,
-- 
Dave Goldberg
david.goldberg6@verizon.net




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: address parsing problem in latest CVS
  2006-09-07  3:28 address parsing problem in latest CVS Dave Goldberg
@ 2006-09-07  4:47 ` Katsumi Yamaoka
  2006-09-07  9:54   ` Katsumi Yamaoka
  0 siblings, 1 reply; 6+ messages in thread
From: Katsumi Yamaoka @ 2006-09-07  4:47 UTC (permalink / raw)
  Cc: ding

>>>>> In <x7lkow5p9b.fsf@davestoy.homelinux.org> Dave Goldberg wrote:

> I'm back from a couple week's vacation and at work did a CVS update
> before getting into email with Gnus.  I've found that the patches from
> 9/1 with the following ChangeLog entry have resulted in broken
> addresses being passed to smtpmail:

> 2006-09-01  Katsumi Yamaoka  <yamaoka@jpl.org>

[...]

> The symptom looks like this (addresses sanitized):

> 220 exchange.work.ORG Microsoft ESMTP MAIL Service, Version: 6.0.3790.1830 ready at  Wed, 6 Sep 2006 15:57:54 -0400

[...]

> MAIL FROM: <me@work.org> SIZE=3565
> 250 2.1.0 me@work.org....Sender OK
> RCPT TO: <someone@yahoo.com>
> 250 2.1.5 someone@yahoo.com
> RCPT TO: <"\\_^_<someoneelse\\@work.org\\>\\")>

[...]

> The address in question is always the first on the CC line.  Most of
> my addresses are of the form "Real Name" <user@whatever.com>.

I started to test it using XEmacs 21.4.19, however I couldn't
find a way to reproduce such a funny quoting so far.  Could you
let me know exactly how the headers which concern this were in
the message buffer?

Regards,



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: address parsing problem in latest CVS
  2006-09-07  4:47 ` Katsumi Yamaoka
@ 2006-09-07  9:54   ` Katsumi Yamaoka
  2006-09-07 10:08     ` Katsumi Yamaoka
  0 siblings, 1 reply; 6+ messages in thread
From: Katsumi Yamaoka @ 2006-09-07  9:54 UTC (permalink / raw)
  Cc: ding

>>>>> In <b4mslj4i8p3.fsf@jpl.org> Katsumi Yamaoka wrote:

> I started to test it using XEmacs 21.4.19, however I couldn't
> find a way to reproduce such a funny quoting so far.  Could you
> let me know exactly how the headers which concern this were in
> the message buffer?

I found it.  If there are two or more addresses in a header like
the following,

  To: "foo bar" <foo@bar>, "foo bar" <foo@bar>

they will be encoded into:

  To: "foo bar" \<foo\@bar\>\, "foo bar" <foo@bar>

I've fixed the bug in both the v5-10 branch and the trunk.
Could you try the fixed one?  You can use the `C-u C-c C-m P'
command in the message buffer to see how the quoting is done.

Thank you very much for discovering this bug.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: address parsing problem in latest CVS
  2006-09-07  9:54   ` Katsumi Yamaoka
@ 2006-09-07 10:08     ` Katsumi Yamaoka
  2006-09-07 12:01       ` Katsumi Yamaoka
  0 siblings, 1 reply; 6+ messages in thread
From: Katsumi Yamaoka @ 2006-09-07 10:08 UTC (permalink / raw)
  Cc: ding

>>>>> In <b4mpse8knn2.fsf@jpl.org> Katsumi Yamaoka wrote:

> I've fixed the bug in both the v5-10 branch and the trunk.

I've fixed it again slightly.  Please use the latest one if
you've checked it out just after reading my last message.
Sorry.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: address parsing problem in latest CVS
  2006-09-07 10:08     ` Katsumi Yamaoka
@ 2006-09-07 12:01       ` Katsumi Yamaoka
  2006-09-07 13:09         ` Dave Goldberg
  0 siblings, 1 reply; 6+ messages in thread
From: Katsumi Yamaoka @ 2006-09-07 12:01 UTC (permalink / raw)
  Cc: ding

>>>>> In <b4m3bb4j8f5.fsf@jpl.org> Katsumi Yamaoka wrote:
>>>>>> In <b4mpse8knn2.fsf@jpl.org> Katsumi Yamaoka wrote:

>> I've fixed the bug in both the v5-10 branch and the trunk.

> I've fixed it again slightly.  Please use the latest one if
> you've checked it out just after reading my last message.
> Sorry.

I've fixed it further now (v5-10 branch and trunk).  I'm sorry
to post such messages so many times.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: address parsing problem in latest CVS
  2006-09-07 12:01       ` Katsumi Yamaoka
@ 2006-09-07 13:09         ` Dave Goldberg
  0 siblings, 0 replies; 6+ messages in thread
From: Dave Goldberg @ 2006-09-07 13:09 UTC (permalink / raw)


>>>>> On Thu, 07 Sep 2006 21:01:04 +0900, Katsumi Yamaoka <yamaoka@jpl.org> #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( said:

>>>>> In <b4m3bb4j8f5.fsf@jpl.org> Katsumi Yamaoka wrote:
>>>>>>> In <b4mpse8knn2.fsf@jpl.org> Katsumi Yamaoka wrote:

>>> I've fixed the bug in both the v5-10 branch and the trunk.

>> I've fixed it again slightly.  Please use the latest one if
>> you've checked it out just after reading my last message.
>> Sorry.

> I've fixed it further now (v5-10 branch and trunk).  I'm sorry
> to post such messages so many times.

I just tested it - it works fine now.  Thanks very much for the quick
fix.  And thanks for the pointer to C-u C-c C-m P - I occasionally
deal with MIME fixes by hand when forwarding stuff and wanting to
strip attachments.  That is a very useful feature.
-- 
Dave Goldberg
david.goldberg6@verizon.net




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2006-09-07 13:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-09-07  3:28 address parsing problem in latest CVS Dave Goldberg
2006-09-07  4:47 ` Katsumi Yamaoka
2006-09-07  9:54   ` Katsumi Yamaoka
2006-09-07 10:08     ` Katsumi Yamaoka
2006-09-07 12:01       ` Katsumi Yamaoka
2006-09-07 13:09         ` Dave Goldberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).