Re: spam.el is a bit aggressive loading/saving spam-stat data

[David Z Maze <dmaze@MIT.EDU>]

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

Ted Zlatanov <tzz@lifelogs.com> writes:

> On Tue, 25 Feb 2003, dmaze@MIT.EDU wrote:
>> Could you also make the parallel change with spam-stat-load?  It
>> could be added to perhaps gnus-get-new-news-hook, and then removed
>> from spam-split.  (A little tricky; you want to make sure it's
>> loaded when Gnus is first started, but don't want to lose updated
>> data when you rescan groups.)
>
> Oh, I see the problem.  Sorry!  Fixed, I moved spam-stat-load to
> gnus-get-new-news-hook as you suggested.

Well, the good news: Gnus no longer takes multiple seconds per message
to read mail.  :-)  The bad news, part 1, is that this only works if
spam-use-stat is defined before spam.el is loaded.  (So if you
(require 'spam) at the top of your .gnus, say, you lose.)  This patch
fixes that:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: spam.el.diff --]
[-- Type: text/x-patch, Size: 940 bytes --]

Index: spam.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/spam.el,v
retrieving revision 6.77
diff -u -r6.77 spam.el
--- spam.el	28 Feb 2003 21:33:47 -0000	6.77
+++ spam.el	1 Mar 2003 13:40:08 -0000
@@ -810,10 +810,15 @@
 	       (insert article-string)
 	       (spam-stat-buffer-is-non-spam))))))
 
+      (defun spam-maybe-spam-stat-load ()
+	(if spam-use-stat (spam-stat-load)))
+
+      (defun spam-maybe-spam-stat-save ()
+	(if spam-use-stat (spam-stat-save)))
+
       ;; Add hooks for loading and saving the spam stats
-      (when spam-use-stat
-	(add-hook 'gnus-save-newsrc-hook 'spam-stat-save)
-	(add-hook 'gnus-get-new-news-hook 'spam-stat-load)))
+      (add-hook 'gnus-save-newsrc-hook 'spam-maybe-spam-stat-save)
+      (add-hook 'gnus-get-new-news-hook 'spam-maybe-spam-stat-load))
 
   (file-error (progn
 		(defalias 'spam-stat-register-ham-routine 'ignore)

[-- Attachment #3: Type: text/plain, Size: 574 bytes --]


Even with that, spam-stat-load doesn't seem to get called when Gnus is
loaded.  What in gnus-1 causes incoming mail to be read on startup?
The only call to gnus-group-get-new-news there is protected by a call
to gnus-alive-p, and the code seems to leap from reading in all of the
prerequisite files to building the group buffer.  Does something in
the startup sequence actually run gnus-get-new-news-hook?

-- 
David Maze             dmaze@mit.edu          http://www.mit.edu/~dmaze/
"Theoretical politics is interesting.  Politicking should be illegal."
	-- Abra Mitchell