Oort Gnus v0.19 is released

Oort Gnus v0.19 is released

[Lars Magne Ingebrigtsen]

And we're now in feature freeze.  Please test this one in particular;
we want to have the actual release of Gnus 5.10 on Thursday actually
working. 

Get it from <URL:http://quimby.gnus.org/gnus/dist/ognus-0.19.tar.gz>
or "/ftp@quimby.gnus.org:/pub/gnus/".  The patch is available as
<URL:ftp://quimby.gnus.org/pub/gnus/ding-patches/ognus-0.18-0.19.diff.gz>.

ChangeLog since last release:

2003-04-27 06:47:31 Lars Magne Ingebrigtsen <lars@ingebrigtsen.no>

	* gnus.el: Oort Gnus v0.19 is released.

2003-04-27  Kevin Greiner <kgreiner@xpediantsolutions.com>

	* gnus-registry.el (gnus-register-spool-action): Replaced literal
	carriage-return character with its escape sequence.

2003-04-27  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* gnus-sum.el (gnus-summary-catchup-from-here): Doc fix.

	* nnrss.el (nnrss-node-text): Use only one
	gnus-replace-in-string. 

	* gnus.el: Remove gnus-functionp throughout.

	* gnus-util.el (gnus-functionp): Removed.

	* gnus-msg.el (gnus-summary-wide-reply-with-original): Doc fix. 

	* message.el (message-required-headers): Add In-Reply-To.

2003-04-27  Marshall T. Vandegrift  <vandem2@rpi.edu>

	* gnus-fun.el (gnus-face-from-file): Bind coding-system-for-read
	to binary.

2003-04-27  Jesper Harder  <harder@ifa.au.dk>

	* mml.el (mml-preview): do.

	* message.el (message-mode): do.

	* gnus-undo.el (gnus-undo-mode): do.

	* gnus-topic.el (gnus-topic-mode): do.

	* gnus-sum.el (gnus-summary-mode, gnus-summary-edit-article): do.

	* gnus-msg.el (gnus-setup-message)
	(gnus-inews-add-send-actions, gnus-configure-posting-styles): do.

	* gnus-gl.el (gnus-grouplens-mode): do.

	* gnus-art.el (gnus-mime-save-part-and-strip)
	(gnus-mime-delete-part): Use it.

	* gnus-util.el (gnus-make-local-hook): New function.

2003-04-25  Simon Josefsson  <jas@extundo.com>

	* nnrss.el (nnrss-node-text): Don't use a star.
	(nnrss-node-text): Use g-r-i-s, not g-r-r-i-s which doesn't exist.

2003-04-24  Dave Love  <fx@gnu.org>

	* qp.el (quoted-printable-decode-region): Use mm-insert-byte.
	Signal error on malformed text, as for base64.
	(quoted-printable-encode-region): DTRT in Emacs 22.

	* mm-util.el (mm-make-temp-file, mm-insert-byte): New.
	(mm-auto-save-coding-system): Consider utf-8-emacs.
	(mm-mime-mule-charset-alist, mm-mule-charset-to-mime-charset)
	(mm-charset-to-coding-system, mm-mime-charset)
	(mm-find-mime-charset-region): Check for :mime-charset coding
	systems property.

	* mml-sec.el (mml2015, mml1991): Don't require.
	(mml2015-sign, mml2015-encrypt, mml1991-sign, mml1991-encrypt) 
	(message-goto-body, mml-insert-tag): Autoload.

	* mm-decode.el (mm-tmp-directory): Re-write to help avoid warnings.

	* gnus-start.el (message-make-date): Autoload rather than
	requiring message.

	* gnus-group.el (gnus-group-name-charset-group-alist): Use
	mm-coding-system-p.
	(gnus-cache-active-altered): Defvar when compiling.
	(gnus-group-delete-group): Re-write to help avoid warnings.

	* gnus-art.el (gnus-use-idna): Use mm-coding-system-p.

	* pgg.el: Split eval-when-compile forms.

2003-04-24  Reiner Steib  <Reiner.Steib@gmx.de>

	* gnus-group.el (gnus-large-ephemeral-newsgroup) 
	(gnus-fetch-old-ephemeral-headers): News variables.
	(gnus-group-read-ephemeral-group): Use them.

2003-04-24  Simon Josefsson  <jas@extundo.com>

	* sieve.el (sieve-upload): Don't use replace-regexp-in-string.

	* nnrss.el (nnrss-node-text): Ditto.

2003-04-24  Katsumi Yamaoka  <yamaoka@jpl.org>

	* gnus-msg.el (gnus-inews-do-gcc): Make sure the obsolete variable
	gnus-inews-mark-gcc-as-read exists.

2003-04-23  Simon Josefsson  <jas@extundo.com>

	* gnus-sieve.el (gnus-sieve-generate): Rewrite regexp search so it
	doesn't exceed the regexp stack space.

2003-04-23  Jesper Harder  <harder@ifa.au.dk>

	* gnus-msg.el (gnus-inews-mark-gcc-as-read): Don't defvar it.

	* gnus-art.el (gnus-article-hide-pgp-hook): do.

2003-04-23  Reiner Steib  <Reiner.Steib@gmx.de>

	* mml.el (mml-preview): Bind `=', RET, and mouse-2.

2003-04-23  Jesper Harder  <harder@ifa.au.dk>

	* mm-bodies.el (mm-decode-body): Don't override supplied charset.

2003-04-23  Katsumi Yamaoka  <yamaoka@jpl.org>

	* dgnushack.el (merge, copy-list): Remove compiler macros.
	(butlast): Add a compiler macro.

2003-04-22  Paul Jarc  <prj@po.cwru.edu>

	* gnus-util.el (gnus-merge): Added "type" argument to match CL
	merge and gnus-sum.el's expectations.

2003-04-21  Reiner Steib  <Reiner.Steib@gmx.de>

	* gnus-art.el (gnus-button-url-regexp): Added nntp.

	* message.el (message-generate-headers-first): Default to
	'(references).

	* gnus-art.el (gnus-mime-delete-part): Require confirmation.

2003-04-21  Jesper Harder  <harder@ifa.au.dk>

	* smime.el (smime-decrypt-region): Insert From header.

2003-04-21  Kai Großjohann  <kai.grossjohann@gmx.net>

	* gnus-fun.el (gnus-face-from-file, gnus-convert-png-to-face):
	Max length of header is 726, not 740.  From Gaute B Strokkenes
	<gs234@cam.ac.uk>.

2003-04-20  Jesper Harder  <harder@ifa.au.dk>

	* nndb.el, mml1991.el: Fix license template.

2003-04-20  Simon Josefsson  <jas@extundo.com>

	* nnimap.el (nnimap-split-articles): Don't download body unless
	required.

	* imap.el (imap-gssapi-open, imap-ssl-open): Erase buffer before
	starting process, like imap-kerberos4-open does.

	* mml-smime.el, rfc1843.el, dig.el, smime.el, uudecode.el: Fix
	license template.

	* mml-sec.el: Fix license template.

	* gnus-sieve.el, sieve.el, sieve-manage.el, sieve-mode.el: Fix
	license template.

	* pgg-def.el, pgg.el, pgg-gpg.el, pgg-parse.el, pgg-pgp5.el,
	pgg-pgp.el: Fix license template.

2003-04-19  Jesper Harder  <harder@ifa.au.dk>

	* gnus-sum.el (gnus-summary-delete-article): Improve docstring.

2003-04-19  Teodor Zlatanov  <tzz@lifelogs.com>

	* spam.el (spam-move-spam-nonspam-groups-only): dumb typo fix

2003-04-18  Teodor Zlatanov  <tzz@lifelogs.com>

	* spam.el (spam-split): allow a particular check as a parameter,
	e.g. (: spam-split 'spam-use-bogofilter)
	(spam-mark-only-unseen-as-spam): new parameter, see doc
	(spam-mark-junk-as-spam-routine): use
	spam-mark-only-unseen-as-spam, simplify routine to take advantage
	of gnus-newsgroup-unread as well as gnus-newsgroup-unseen

2003-04-17  Teodor Zlatanov  <tzz@lifelogs.com>

	* gnus.el (gnus-group-short-name, gnus-group-prefixed-p): new functions
	(gnus-group-guess-full-name): don't prefix the group twice

	* nnmail.el (nnmail-split-fancy-with-parent): docstring fix

	* gnus-registry.el (gnus-registry-clear)
	(gnus-registry-fetch-group, gnus-registry-grep-in-list)
	(gnus-registry-split-fancy-with-parent): new functions
	(gnus-register-spool-action, gnus-register-action): simplified the format
	(gnus-registry): new customization group
	(gnus-registry-unfollowed-groups): new variable

2003-04-17  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* gnus-art.el (gnus-button-alist): Add nntp: urls.
	(gnus-header-button-alist): Ditto.

2003-04-17  Dave Love  <fx@gnu.org>

	* gnus-util.el (gnus-string-equal): Revert last change.

2003-04-17  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* gnus-srvr.el (gnus-browse-make-menu-bar): Fix typo.

2003-04-17  Mike Woolley  <mike@ariel.co.uk>

	* gnus-sum.el (gnus-sum-thread-tree-false-root): New variable.

2003-04-15  Michael Shields  <shields@msrl.com>

	* gnus-art.el (article-hide-boring-headers): Hide Reply-To: if
	the broken-reply-to group parameter is set.  Idea from Vasily
	Korytov <deskpot@myrealbox.com>.

2003-04-17  Steve Youngs  <youngs@xemacs.org>

	* dgnushack.el: 'setenv' is in env.el for XEmacsen <= 21.4, but in
	process.el in XEmacsen >= 21.5.

2003-04-17  Steve Youngs  <youngs@xemacs.org>

	* dgnushack.el: Add a whole swag of autoloads and defaliases to
	satisfy the byte-compiler when building with XEmacs.

	* lpath.el (maybe-bind): Add 'w3-meta-content-type-charset-regexp'
	and 'w3-meta-charset-content-type-regexp' in XEmacs.  The upstream
	W3 doesn't have these.

	* mailcap.el: Maybe require 'lpr in XEmacs.

2003-04-16  Simon Josefsson  <jas@extundo.com>

	* mml2015.el (mml2015-pgg-sign): Bind pgg-default-user-id to MML
	sender tag, if available.

2003-04-16  Teodor Zlatanov  <tzz@lifelogs.com>

	* gnus-registry.el (gnus-register-action)
	(gnus-register-spool-action, hashtable-to-alist)
	(gnus-registry-translate-from-alist, alist-to-hashtable)
	(gnus-registry-translate-to-alist, gnus-registry-headers-hashtb):
	new variables and function fixes

	* gnus.el (gnus-registry-headers-alist): new variable to hold
	article header data
	(gnus-variable-list): save gnus-registry-headers-alist

	* spam-report.el (Module): new module for spam reporting

	* gnus.el (spam-process): added
	gnus-group-spam-exit-processor-report-gmane to the list of choices
	(gnus-install-group-spam-parameters): defined new spam exit processor

	* spam.el (autoload): autoload spam-report-gmane when needed
	(spam-report-gmane-register-routine): glue for spam-report.el
	(spam-group-spam-processor-report-gmane-p): glue for the
	gnus-group-spam-exit-processor-report-gmane spam processor
	(spam-summary-prepare-exit): check the report-gmane spam processor
	and run spam-report-gmane-register-routine if it's active

	From John Wiegley <johnw@gnu.org>

	* spam.el (spam-bogofilter-score): check bogofilter headers before
	checking bogofilter itself

2003-04-16  Dave Love  <fx@gnu.org>

	* gnus-agent.el: Wrap defsetf in eval-when-compile.
	(gnus-agent-cat-defaccessor): Don't use gensym.

	* mml1991.el: Require cl, mm-util when compiling.
	(quoted-printable-decode-region, quoted-printable-encode-region):
	Autoload.

	* pgg.el: Require cl when compiling.

	* nnmail.el (gnus): Require.

	* gnus-util.el: Move provide to end.
	(gnus-string-equal): Maybe use compare-strings.
	(gnus-merge): New.

	* gnus-sum.el (gnus-summary-prepare-threads): Don't use copy-list.
	(gnus-summary-insert-articles): Use gnus-merge.

	* gnus-fun.el: Require cl and mm-util when compiling.

	* gnus-diary.el (gnus-diary-delay-format-french)
	(gnus-diary-delay-format-english): Don't use setf with nthcdr.

	* nndiary.el (nndiary-compute-reminders): Don't use setf with
	nthcdr.

2003-04-16  Kevin Greiner <kgreiner@xpediantsolutions.com>

	* gnus-agent.el (gnus-agent-make-cat): Added optional parameter to
	specify a predicate other than false.
	(gnus-category-read): Use the new feature to create a 'default'
	category with a 'short' predicate.

2003-04-16  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* message.el (message-unique-id): Comment change.

	* gnus-art.el (gnus-article-next-page-1): New function.
	(gnus-article-next-page): Use it.

2003-04-15  Teodor Zlatanov  <tzz@lifelogs.com>

	* spam.el (spam-split): added save-restriction to save-excursion

2003-04-15  Reiner Steib  <Reiner.Steib@gmx.de>
	From Julien Avarre <julien@avarre.com>

	* gnus-fun.el: Fixed autoload cookie.

2003-04-15  Paul Jarc  <prj@po.cwru.edu>
	From Remi Letot  <remi.letot@easynet.be>

	* nnmaildir.el (nnmaildir-request-scan): Use gnus-remove-if
	instead of remove-if.

2003-04-14  Katsumi Yamaoka  <yamaoka@jpl.org>

	* gnus-msg.el (gnus-summary-news-other-window): Use delq and
	copy-sequence instead of remove which is a cl run-time function in
	Emacs 20.

2003-04-14  Jesper Harder  <harder@ifa.au.dk>

	* gnus-msg.el (gnus-summary-news-other-window): Make a buffer
	local copy of gnus-discouraged-post-methods with the current
	method removed.

2003-04-14  Simon Josefsson  <jas@extundo.com>

	* mailcap.el (mailcap-mime-data): Add application/pgp-keys.

2003-04-13  Reiner Steib  <Reiner.Steib@gmx.de>

	* mm-util.el (mm-sort-coding-systems-predicate): Convert elements
	of `mm-coding-system-priorities' to base coding system.

	* gnus-sum.el: Added coding cookie ("middle dot" in
	gnus-summary-morse-message).

2003-04-13  Simon Josefsson  <jas@extundo.com>

	* gnus-art.el (article-fill-long-lines)
	(article-verify-x-pgp-sig, article-decode-group-name)
	(gnus-mime-button-menu): Split >80 character lines.

2003-04-13  Jesper Harder  <harder@ifa.au.dk>

	* gnus-sum.el (gnus-summary-local-variables): Use defvar since
	we're let-binding it.

	* nnmbox.el (nnmbox-mbox-buffer): It's not a constant.

2003-04-13  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* message.el (message-hide-headers): Don't do intangible.

	* gnus.el (gnus-group-prefixed-name): Comment out the test for
	colon. 

	* gnus-srvr.el (gnus-browse-read-group): Don't give the real name
	to the ephemeral entry, but the prefixed name.

	* gnus.el (gnus-group-prefixed-name): Clean up.

2003-04-13  Kevin Greiner <kgreiner@xpediantsolutions.com>

	* gnus-agent.el (gnus-agent-group-pathname): Bind
	gnus-command-method so that gnus-agent-directory will always
	return a valid directory.
	* gnus-cache.el (gnus-cache-enter-article): Remove article from
	gnus-newsgroup-undownloaded so that the summary will display the
	article as downloaded.
	(gnus-cache-remove-article): If the article isn't in the agent,
	remove it from gnus-newsgroup-undownloaded so that the summary
	will display the article as undownloaded.

2003-04-13  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* gnus.el (gnus-version-number): Bump.



-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Oort Gnus v0.19 is released

[Romain FRANCOISE]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> And we're now in feature freeze.  Please test this one in particular;
> we want to have the actual release of Gnus 5.10 on Thursday actually
> working. 

Somewhere during 0.19, someone changed message.el and now I see
References:, In-Reply-To: and other headers while composing a reply.  Is
that intentional?

Also, it might be caused by something in my setup but sometimes when the
message buffer shows up, the headers are all messed up: the From is lost
in lesser-importance headers, To: and Cc: are at the top...  I was used
to have From: on the first line, and now I'm all confused!  :-)

-- 
Romain FRANCOISE <romain@orebokech.com> | Last night the whole of hell
it's a miracle -- http://orebokech.com/ | came down to bathe and dine
                                        | with us.

Re: Oort Gnus v0.19 is released

[Florian Weimer]

Romain FRANCOISE <romain@orebokech.com> writes:

> Somewhere during 0.19, someone changed message.el and now I see
> References:, In-Reply-To: and other headers while composing a reply.  Is
> that intentional?

I hope so, I think this is the right thing to do.

Re: Oort Gnus v0.19 is released

[Lars Magne Ingebrigtsen]

Romain FRANCOISE <romain@orebokech.com> writes:

> Also, it might be caused by something in my setup but sometimes when the
> message buffer shows up, the headers are all messed up: the From is lost
> in lesser-importance headers, To: and Cc: are at the top...  I was used
> to have From: on the first line, and now I'm all confused!  :-)

The headers can be in any old order...

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Oort Gnus v0.19 is released

[Lars Magne Ingebrigtsen]

Florian Weimer <fw@deneb.enyo.de> writes:

>> Somewhere during 0.19, someone changed message.el and now I see
>> References:, In-Reply-To: and other headers while composing a reply.  Is
>> that intentional?
>
> I hope so, I think this is the right thing to do.

Yes, but the headers should be hidden in some way.

And making them invisible (as happens with some headers now) has
turned out to not be the best way to do that.

Perhaps they should be written to a temporary file in the drafts
directory instead.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Oort Gnus v0.19 is released

[Vasily Korytov]

[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]

On Sun, 27 Apr 2003 10:05:08 +0200, Romain FRANCOISE wrote:

> Somewhere during 0.19, someone changed message.el and now I see
> References:, In-Reply-To: and other headers while composing a reply.  Is
> that intentional?

See this thread: <news:v9r88n1bh0.fsf@marauder.physik.uni-ulm.de>.

And this variable:

,----[ C-h v message-generate-headers-first RET ]
| `message-generate-headers-first' is a variable declared in Lisp.
|   -- loaded from "message"
| 
| Value: nil
| 
| Documentation:
| *If non-nil, generate all required headers before composing.
| The variables `message-required-news-headers' and
| `message-required-mail-headers' specify which headers to generate.
| This can also be a list of headers that should be generated before
| composing.
| 
| Note that the variable `message-deletable-headers' specifies headers which
| are to be deleted and then re-generated before sending, so this variable
| will not have a visible effect for those headers.
`----

-- 
       I accept RFC3156 and RFC2440-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Oort Gnus v0.19 is released

[Romain FRANCOISE]

deskpot@despammed.com (Vasily Korytov) writes:

> See this thread: <news:v9r88n1bh0.fsf@marauder.physik.uni-ulm.de>.

Ah, that makes good sense indeed.  Thanks.

-- 
Romain FRANCOISE <romain@orebokech.com> | They're nothing but cold
it's a miracle -- http://orebokech.com/ | little demons.

Re: Oort Gnus v0.19 is released

[Romain FRANCOISE]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Yes, but the headers should be hidden in some way.

Maybe by putting them at the very top of the buffer and narrowing to
the region below them?  Hm, this sounds like a mega-kludge.  :-)

We still have time to think of a good solution since it will be for No
Gnus anyway...

-- 
Romain FRANCOISE <romain@orebokech.com> | With your feet in the air and
it's a miracle -- http://orebokech.com/ | your head on the ground.

Re: Oort Gnus v0.19 is released

[Romain FRANCOISE]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> The headers can be in any old order...

I don't think it happened before.  Not that big a deal, anyway...

-- 
Romain FRANCOISE <romain@orebokech.com> | When we were kids, we hated
it's a miracle -- http://orebokech.com/ | things our parents did.

Re: Oort Gnus v0.19 is released

[Lars Magne Ingebrigtsen]

Romain FRANCOISE <romain@orebokech.com> writes:

> Maybe by putting them at the very top of the buffer and narrowing to
> the region below them?  Hm, this sounds like a mega-kludge.  :-)

That's a possibility!  I hadn't thought of that...

> We still have time to think of a good solution since it will be for No
> Gnus anyway...

No, the current behavior is to make posting-style stuff invisible,
and that's very error-prone.  It has to be fixed.  I think narrowing
is the best fix, probably.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Oort Gnus v0.19 is released

[Matthias Andree]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> And we're now in feature freeze.  Please test this one in particular;
> we want to have the actual release of Gnus 5.10 on Thursday actually
> working. 

The current CVS stuff throws some messages when compiling:

Wrote /home/emma/cvs-3rdparty/gnus/lisp/format-spec.elc
While compiling gnus-agent-get-undownloaded-list in file /home/emma/cvs-3rdparty/gnus/lisp/gnus-agent.el:
  ** `(car (prog1 alist (setq alist (cdr alist))))' called for effect
  ** `(car (prog1 headers (setq headers (cdr headers))))' called for effect
  ** `(car (prog1 alist (setq alist (cdr alist))))' called for effect
  ** `(car (prog1 headers (setq headers (cdr headers))))' called for effect
While compiling gnus-agent-uncached-articles in file /home/emma/cvs-3rdparty/gnus/lisp/gnus-agent.el:
  ** `(car (prog1 arts (setq arts (cdr arts))))' called for effect
While compiling gnus-agent-regenerate-group in file /home/emma/cvs-3rdparty/gnus/lisp/gnus-agent.el:
  ** `(car (prog1 downloaded (setq downloaded (cdr downloaded))))' called for effect
  ** `(car (prog1 o (setq o (cdr o))))' called for effect
Wrote /home/emma/cvs-3rdparty/gnus/lisp/gnus-agent.elc
...
While compiling gnus-multi-decode-header in file /home/emma/cvs-3rdparty/gnus/lisp/gnus-art.el:
  ** `(car (prog1 xlist (setq xlist (cdr xlist))))' called for effect
Wrote /home/emma/cvs-3rdparty/gnus/lisp/gnus-art.elc
While compiling gnus-async-prefetch-article in file /home/emma/cvs-3rdparty/gnus/lisp/gnus-async.el:
  ** `(car (prog1 gnus-async-fetch-list (setq gnus-async-fetch-list (cdr gnus-async-fetch-list))))' called for effect
Wrote /home/emma/cvs-3rdparty/gnus/lisp/gnus-async.elc
...
While compiling gnus-group-sort-flat in file /home/emma/cvs-3rdparty/gnus/lisp/gnus-group.el:
  ** `(car (prog1 gnus-newsrc-alist (setq gnus-newsrc-alist (cdr gnus-newsrc-alist))))' called for effect
Wrote /home/emma/cvs-3rdparty/gnus/lisp/gnus-group.elc
...
Wrote /home/emma/cvs-3rdparty/gnus/lisp/gnus-kill.elc
While compiling gnus-advanced-score-rule in file /home/emma/cvs-3rdparty/gnus/lisp/gnus-logic.el:
  ** `(car (prog1 rule (setq rule (cdr rule))))' called for effect
  ** `(car (prog1 rule (setq rule (cdr rule))))' called for effect
Wrote /home/emma/cvs-3rdparty/gnus/lisp/gnus-logic.elc
...
While compiling gnus-remove-from-range in file /home/emma/cvs-3rdparty/gnus/lisp/gnus-range.el:
  ** `(car (prog1 range2 (setq range2 (cdr range2))))' called for effect
  ** `(car (prog1 range1 (setq range1 (cdr range1))))' called for effect
  ** `(car (prog1 range2 (setq range2 (cdr range2))))' called for effect
  ** `(car (prog1 range2 (setq range2 (cdr range2))))' called for effect
  ** `(car (prog1 range1 (setq range1 (cdr range1))))' called for effect
  ** `(car (prog1 range1 (setq range1 (cdr range1))))' called for effect
  ** `(car (prog1 range1 (setq range1 (cdr range1))))' called for effect
  ** `(car (prog1 range1 (setq range1 (cdr range1))))' called for effect
Wrote /home/emma/cvs-3rdparty/gnus/lisp/gnus-range.elc

and many more of them.

$ emacs --version
GNU Emacs 21.3.1

-- 
Matthias Andree

Re: Oort Gnus v0.19 is released

[Lars Magne Ingebrigtsen]

Matthias Andree <ma@dt.e-technik.uni-dortmund.de> writes:

> The current CVS stuff throws some messages when compiling:
>
> Wrote /home/emma/cvs-3rdparty/gnus/lisp/format-spec.elc
> While compiling gnus-agent-get-undownloaded-list in file /home/emma/cvs-3rdparty/gnus/lisp/gnus-agent.el:
>   ** `(car (prog1 alist (setq alist (cdr alist))))' called for effect

So, how does one switch off these warnings?

(All these messages are about `pop'.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Oort Gnus v0.19 is released

[Lars Magne Ingebrigtsen]

Matthias Andree <ma@dt.e-technik.uni-dortmund.de> writes:

> The current CVS stuff throws some messages when compiling:

Did you get those messages when saying "make"?

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Oort Gnus v0.19 is released

[Florian Weimer]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Matthias Andree <ma@dt.e-technik.uni-dortmund.de> writes:
>
>> The current CVS stuff throws some messages when compiling:
>
> Did you get those messages when saying "make"?

Yes, I did.

Re: Oort Gnus v0.19 is released

[Sebastian D.B. Krause]

On 3525 September 1993, Florian Weimer wrote:
> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>> Matthias Andree <ma@dt.e-technik.uni-dortmund.de> writes:
>>> The current CVS stuff throws some messages when compiling:
>>
>> Did you get those messages when saying "make"?
>
> Yes, I did.

It seems that you only get these messages with Emacs 21.3 (at least
with the Debian packages of emacs21 21.3-1), not with Emacs 21.2.

Sebastian

Re: Oort Gnus v0.19 is released

[Matthias Andree]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Matthias Andree <ma@dt.e-technik.uni-dortmund.de> writes:
>
>> The current CVS stuff throws some messages when compiling:
>
> Did you get those messages when saying "make"?

Yes, I did. (I tried make clean and make to see if they go away.) They
have been showing up for some days now.

-- 
Matthias Andree

Re: Oort Gnus v0.19 is released

[Romain FRANCOISE]

Matthias Andree <ma@dt.e-technik.uni-dortmund.de> writes:

> They have been showing up for some days now.

Let me guess... since you upgraded to Emacs 21.3?  21.2 didn't show
these warnings, and Emacs from CVS doesn't either, so it's probably 21.3
specific, and hence safe to ignore.

-- 
Romain FRANCOISE <romain@orebokech.com> | Last night the whole of hell
it's a miracle -- http://orebokech.com/ | came down to bathe and dine
                                        | with us.

Re: Oort Gnus v0.19 is released

[Simon Josefsson]

Romain FRANCOISE <romain@orebokech.com> writes:

> Matthias Andree <ma@dt.e-technik.uni-dortmund.de> writes:
>
>> They have been showing up for some days now.
>
> Let me guess... since you upgraded to Emacs 21.3?  21.2 didn't show
> these warnings, and Emacs from CVS doesn't either, so it's probably 21.3
> specific, and hence safe to ignore.

Why should we ignore 21.3?  It is the latest stable release, so
ignoring it doesn't seem ideal to me.

Re: Oort Gnus v0.19 is released

[Romain FRANCOISE]

Simon Josefsson <jas@extundo.com> writes:

> Why should we ignore 21.3?  It is the latest stable release, so
> ignoring it doesn't seem ideal to me.

I meant ignore the warnings, not 21.3.  They shouldn't be there in the
first place, Emacs from CVS has this fix installed:

2002-10-13  Richard M. Stallman  <rms@gnu.org>

	* emacs-lisp/byte-opt.el (byte-optimize-form-code-walker):
	Treat `ignore' specially--prevent warnings about functions
	called for effect, in its args.
	Don't warn when `pop' is used for effect.

So whatever fix we install in Gnus to prevent Emacs 21.3 from warning
about `pop' will become unnecessary with the next non-bugfix Emacs
release (21.4 or 21.5).

-- 
Romain FRANCOISE <romain@orebokech.com> | Wait, stop, wait just hold on
it's a miracle -- http://orebokech.com/ | a minute.

Re: Oort Gnus v0.19 is released

[Romain FRANCOISE]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> No, the current behavior is to make posting-style stuff invisible, and
> that's very error-prone.  It has to be fixed.  I think narrowing is
> the best fix, probably.

Okay, so do you think you'll have time to implement this before May 1st?

-- 
Romain FRANCOISE <romain@orebokech.com> | There are doors that let you
it's a miracle -- http://orebokech.com/ | in.

Re: Oort Gnus v0.19 is released

[Christoph Garbers]

* Lars Magne Ingebrigtsen <larsi@gnus.org>:

> 2003-04-27  Lars Magne Ingebrigtsen  <larsi@gnus.org>
> 
> 	* message.el (message-required-headers): Add In-Reply-To.

Gnus now generates an In-Reply-To:-Header for postings -- IMO this
should be used in e-mails only.

Christoph

Re: Oort Gnus v0.19 is released

[Jesper Harder]

Simon Josefsson <jas@extundo.com> writes:

> Romain FRANCOISE <romain@orebokech.com> writes:
>
>> Matthias Andree <ma@dt.e-technik.uni-dortmund.de> writes:
>>
>>> They have been showing up for some days now.
>>
>> Let me guess... since you upgraded to Emacs 21.3?  21.2 didn't show
>> these warnings, and Emacs from CVS doesn't either, so it's probably 21.3
>> specific, and hence safe to ignore.
>
> Why should we ignore 21.3?  It is the latest stable release, so
> ignoring it doesn't seem ideal to me.

We could replace (pop x) with (setq x (cdr x)) in those places.

There is a grain of truth in the warnings, i.e. that pop is a tiny bit
less efficient when we don't use the return value -- not that I think
anyone would notice the difference.

Re: Oort Gnus v0.19 is released

[Simon Josefsson]

Jesper Harder <harder@myrealbox.com> writes:

> Simon Josefsson <jas@extundo.com> writes:
>
>> Romain FRANCOISE <romain@orebokech.com> writes:
>>
>>> Matthias Andree <ma@dt.e-technik.uni-dortmund.de> writes:
>>>
>>>> They have been showing up for some days now.
>>>
>>> Let me guess... since you upgraded to Emacs 21.3?  21.2 didn't show
>>> these warnings, and Emacs from CVS doesn't either, so it's probably 21.3
>>> specific, and hence safe to ignore.
>>
>> Why should we ignore 21.3?  It is the latest stable release, so
>> ignoring it doesn't seem ideal to me.
>
> We could replace (pop x) with (setq x (cdr x)) in those places.

Or create a gnus-pop macro.

> There is a grain of truth in the warnings, i.e. that pop is a tiny bit
> less efficient when we don't use the return value -- not that I think
> anyone would notice the difference.

The warning has been removed, but I'm not sure I agree it had even a
tiny grain of truth in it -- the docstring for `pop' says "Remove and
return the head of the list stored in PLACE.", and I assume this is
what CL `pop' is supposed to do.  Using it in that way in elisp should
never generate a warning IMHO.

Re: Oort Gnus v0.19 is released

[Jesper Harder]

Simon Josefsson <jas@extundo.com> writes:

> Jesper Harder <harder@myrealbox.com> writes:
>
>> There is a grain of truth in the warnings, i.e. that pop is a tiny bit
>> less efficient when we don't use the return value -- not that I think
>> anyone would notice the difference.
>
> The warning has been removed, but I'm not sure I agree it had even a
> tiny grain of truth in it -- the docstring for `pop' says "Remove and
> return the head of the list stored in PLACE.", and I assume this is
> what CL `pop' is supposed to do.  Using it in that way in elisp should
> never generate a warning IMHO.

I agree that the warning is too pedantic.  But it's still true,
though.  The part to notice in the docstring is

   and return the head of the list
 
If we don't use the return value from pop, then

  (setq x (cdr x))

is obviously more efficient than 

  (pop x) == (car (prog1 x (setq x (cdr x))))

Re: Oort Gnus v0.19 is released

[Kevin Greiner]

Jesper Harder <harder@myrealbox.com> writes:

> Simon Josefsson <jas@extundo.com> writes:
>
>> Jesper Harder <harder@myrealbox.com> writes:
>>
>>> There is a grain of truth in the warnings, i.e. that pop is a tiny bit
>>> less efficient when we don't use the return value -- not that I think
>>> anyone would notice the difference.
>>
>> The warning has been removed, but I'm not sure I agree it had even a
>> tiny grain of truth in it -- the docstring for `pop' says "Remove and
>> return the head of the list stored in PLACE.", and I assume this is
>> what CL `pop' is supposed to do.  Using it in that way in elisp should
>> never generate a warning IMHO.
>
> I agree that the warning is too pedantic.  But it's still true,
> though.  The part to notice in the docstring is
>
>    and return the head of the list
>  
> If we don't use the return value from pop, then
>
>   (setq x (cdr x))
>
> is obviously more efficient than 
>
>   (pop x) == (car (prog1 x (setq x (cdr x))))

Of course, the optimizer should (after printing the warning) remove
the car and prog1 leaving just (setq x (cdr x)).

That being said, I'll probably remove the pop macros in gnus-agent.

Kevin

Re: Oort Gnus v0.19 is released

[Lars Magne Ingebrigtsen]

Jesper Harder <harder@myrealbox.com> writes:

> We could replace (pop x) with (setq x (cdr x)) in those places.

No, no.  `pop' is very clear and nice.  And the byte-code optimizer
will (or should :-) fix everything so that the byte code of the two
should be identical.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Oort Gnus v0.19 is released

[Lars Magne Ingebrigtsen]

Romain FRANCOISE <romain@orebokech.com> writes:

>> No, the current behavior is to make posting-style stuff invisible, and
>> that's very error-prone.  It has to be fixed.  I think narrowing is
>> the best fix, probably.
>
> Okay, so do you think you'll have time to implement this before May 1st?

Uhm...  doesn't look like it.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Oort Gnus v0.19 is released

[Lars Magne Ingebrigtsen]

Christoph Garbers <cgarbers@gmx.de> writes:

> Gnus now generates an In-Reply-To:-Header for postings -- IMO this
> should be used in e-mails only.

Yes.  I've now removed it again.

It's a fairly obscure header even in mail, so I think we'll just let
Gnus 5.10 not generate it in those instances where Emacs crashed
between you typing `F' and `C-c C-c'.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Oort Gnus v0.19 is released

[Lars Magne Ingebrigtsen]

Romain FRANCOISE <romain@orebokech.com> writes:

> I meant ignore the warnings, not 21.3.  They shouldn't be there in the
> first place, Emacs from CVS has this fix installed:
>
> 2002-10-13  Richard M. Stallman  <rms@gnu.org>
>
> 	* emacs-lisp/byte-opt.el (byte-optimize-form-code-walker):
> 	Treat `ignore' specially--prevent warnings about functions
> 	called for effect, in its args.
> 	Don't warn when `pop' is used for effect.

But is there any way to shut up the compiler in Emacs 21.3?

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Oort Gnus v0.19 is released

[Romain FRANCOISE]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> But is there any way to shut up the compiler in Emacs 21.3?

There's always `byte-compile-warnings', but I don't think it's a
solution...  I'd follow Jesper's advice and replace all those offending
pops with good old setqs and cdrs.  :-)

-- 
Romain FRANCOISE <romain@orebokech.com> | That there, that's not me. I
it's a miracle -- http://orebokech.com/ | go where I please.

Re: Oort Gnus v0.19 is released

[Romain FRANCOISE]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

>> Okay, so do you think you'll have time to implement this before May 1st?

> Uhm...  doesn't look like it.  :-)

So will 5.10 ship with invisible headers, or do you plan to cook
something up in the (gasp!) 6 hours and 45 minutes left before the
release?

-- 
Romain FRANCOISE <romain@orebokech.com> | Every sky is blue, but not
it's a miracle -- http://orebokech.com/ | for me and you.

Re: Oort Gnus v0.19 is released

[Lars Magne Ingebrigtsen]

Romain FRANCOISE <romain@orebokech.com> writes:

> So will 5.10 ship with invisible headers, or do you plan to cook
> something up in the (gasp!) 6 hours and 45 minutes left before the
> release?

No headers are invisible per default, so I think I'll just ship it as
is.  Hiding headers can be left as an exercise for No Gnus.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

In-Reply-To header (was: Oort Gnus v0.19 is released)

[Reiner Steib]

On Thu, May 01 2003, Lars Magne Ingebrigtsen wrote:

> Christoph Garbers <cgarbers@gmx.de> writes:
>
>> Gnus now generates an In-Reply-To:-Header for postings -- IMO this
>> should be used in e-mails only.
>
> Yes.  I've now removed it again.
>
> It's a fairly obscure header even in mail, so I think we'll just let
> Gnus 5.10 not generate it in those instances where Emacs crashed
> between you typing `F' and `C-c C-c'.

Isn't it also missing when using drafts?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: In-Reply-To header

[Lars Magne Ingebrigtsen]

Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:

> Isn't it also missing when using drafts?

So it is.  But that's not important enought to fix before 5.10.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Oort Gnus v0.19 is released

[Simon Josefsson]

Romain FRANCOISE <romain@orebokech.com> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
>> But is there any way to shut up the compiler in Emacs 21.3?
>
> There's always `byte-compile-warnings', but I don't think it's a
> solution...  I'd follow Jesper's advice and replace all those offending
> pops with good old setqs and cdrs.  :-)

At least replace it by a gnus-pop.  Replacing it with setq/cdr makes
for unreadable code IMHO.  But I don't think we should change it, the
warning in Emacs 21.3 was incorrect and has been removed now.

Re: Oort Gnus v0.19 is released

[Jan Egil Hagen]

| nnrss stopped working for me after updating.  The error message is the
| same for all my RSS feeds "nnrss: Not valid XML and w3 parse not
| available (/ifi/tyrfing/h11/janha/News/rss/LawrenceLessig.xml)"
| 
| Performing load-library for w3 results in the error message
| "impossible ??" instead.

0.22 still performs the same.  I had to find an old nnrss.el to get it
working again.

-- 
   World works; done by its invalids

Re: Oort Gnus v0.19 is released

[Lars Magne Ingebrigtsen]

Jan Egil Hagen <janha+news@ifi.uio.no> writes:

> | Performing load-library for w3 results in the error message
> | "impossible ??" instead.
>
> 0.22 still performs the same.  I had to find an old nnrss.el to get it
> working again.

`(setq debug-on-error t)', repeat the bug and mail me the resulting
backtrace.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Oort Gnus v0.19 is released

[Jan Egil Hagen]

*Jan Egil Hagen <janha+news@ifi.uio.no>
| 
| | Performing load-library for w3 results in the error message
| | "impossible ??" instead.
| 
| 0.22 still performs the same.  I had to find an old nnrss.el to get it
| working again.
| 

* Lars Magne Ingebrigtsen <larsi@gnus.org>
| `(setq debug-on-error t)', repeat the bug and mail me the resulting
| backtrace.

Debugger entered--Lisp error: (error "impossible ??")
  signal(error ("impossible ??"))
  error("impossible ??")
  w3-parse-buffer(#<buffer  *temp*<2>>)
  (caddar (w3-parse-buffer (current-buffer)))
  (setq htmlform (caddar (w3-parse-buffer ...)))
  (if (fboundp (quote w3-parse-buffer)) (setq htmlform (caddar ...)) (message "nnrss: Not valid XML and w3 parse not available (%s)" url))
  (condition-case err (setq xmlform (xml-parse-region ... ...)) (error (if ... ... ...)))
  (let* (xmlform htmlform) (if local (let ... ...) (mm-url-insert url)) (condition-case err (setq xmlform ...) (error ...)) (if htmlform htmlform xmlform))
  (save-current-buffer (set-buffer temp-buffer) (let* (xmlform htmlform) (if local ... ...) (condition-case err ... ...) (if htmlform htmlform xmlform)))
  (with-current-buffer temp-buffer (let* (xmlform htmlform) (if local ... ...) (condition-case err ... ...) (if htmlform htmlform xmlform)))
  (unwind-protect (with-current-buffer temp-buffer (let* ... ... ... ...)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))
  (let ((temp-buffer ...)) (unwind-protect (with-current-buffer temp-buffer ...) (and ... ...)))
  (with-temp-buffer (let* (xmlform htmlform) (if local ... ...) (condition-case err ... ...) (if htmlform htmlform xmlform)))
  nnrss-fetch("/hom/janha/News/rss/LawrenceLessig.xml" t)
  (progn (nnrss-fetch file t))
  (if (and nnrss-use-local (file-exists-p ...)) (progn (nnrss-fetch file t)) (setq url (or ... ...)) (unless url (setq url ...) (let ... ...) (setq changed t)) (message "####") (setq xml (nnrss-fetch url)))
  (let (file xml subject url extra changed author date rss-ns rdf-ns content-ns dc-ns) (if (and nnrss-use-local ...) (progn ...) (setq url ...) (unless url ... ... ...) (message "####") (setq xml ...)) (setq dc-ns (nnrss-get-namespace-prefix xml "http://purl.org/dc/elements/1.1/") rdf-ns (nnrss-get-namespace-prefix xml "http://www.w3.org/1999/02/22-rdf-syntax-ns#") rss-ns (nnrss-get-namespace-prefix xml "http://purl.org/rss/1.0/") content-ns (nnrss-get-namespace-prefix xml "http://purl.org/rss/1.0/modules/content/")) (dolist (item ...) (when ... ... ... ... ... ... ... ...)) (when changed (nnrss-save-group-data group server) (let ... ...) (nnrss-save-server-data server)))
  nnrss-check-group("LawrenceLessig" "")
  (if dont-check t (nnrss-check-group group server) (nnheader-report (quote nnrss) "Opened group %s" group) (nnheader-insert "211 %d %d %d %s\n" nnrss-group-max nnrss-group-min nnrss-group-max (prin1-to-string group) t))
  nnrss-request-group("LawrenceLessig" "" nil)
  gnus-activate-group("nnrss:LawrenceLessig" scan)
  gnus-get-unread-articles(nil)
  gnus-group-get-new-news(nil)
  call-interactively(gnus-group-get-new-news)
  recursive-edit()
  byte-code("Æ\b!.Ç .È	!.\n.?.Éed\"\vV.4.eb.Ê\v¥y.`.db.Ê\v¥\vZy.\f`|.)Ëc.eb.ÌÍ !.Î .	@Ï=.K.ÐÑÒ\".Ó .ÌÔ!.ÒÕÒ.\x1e.\x1e.ÌÔ!.ŠÖ .,Õ." [debugger-buffer debugger-args noninteractive debugger-batch-max-lines middlestart buffer-read-only pop-to-buffer debugger-mode debugger-setup-buffer count-lines 2 "...\n" message buffer-string kill-emacs debug backtrace-debug 3 t debugger-reenable "" nil recursive-edit standard-output inhibit-trace] 3)
  debug(error (error "impossible ??"))
  signal(error ("impossible ??"))
  error("impossible ??")
  w3-parse-buffer(#<buffer  *temp*>)
  byte-code("ÃÄ!.\x14.Äp!.\x18@A)A@.‚.
  nnrss-fetch("/hom/janha/News/rss/LawrenceLessig.xml" t)
  nnrss-check-group("LawrenceLessig" "")
  nnrss-request-group("LawrenceLessig" "" nil)
  gnus-activate-group("nnrss:LawrenceLessig" scan)
  gnus-get-unread-articles(nil)
  gnus-group-get-new-news(nil)
  call-interactively(gnus-group-get-new-news)

I've tried looking at the code myself, but I just don't get it. :)
Sorry.

-- 
   World works; done by its invalids

Re: Oort Gnus v0.19 is released

[Lars Magne Ingebrigtsen]

Jan Egil Hagen <janha+news@ifi.uio.no> writes:

> Debugger entered--Lisp error: (error "impossible ??")
>   signal(error ("impossible ??"))
>   error("impossible ??")
>   w3-parse-buffer(#<buffer  *temp*<2>>)

What's in the " *temp*<2>" buffer (note leading space) when you get
this backtrace?

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Oort Gnus v0.19 is released

[Christoph Garbers]

* Lars Magne Ingebrigtsen <larsi@gnus.org>:

>> Gnus now generates an In-Reply-To:-Header for postings -- IMO this
>> should be used in e-mails only.
> 
> Yes.  I've now removed it again.

Thanks.
 
Christoph