* Re: A question about smiley.el
1997-07-30 7:22 A question about smiley.el Edvard Majakari
@ 1997-07-30 17:06 ` Danny Siu
1997-07-30 21:44 ` Danny Siu
0 siblings, 1 reply; 3+ messages in thread
From: Danny Siu @ 1997-07-30 17:06 UTC (permalink / raw)
[-- Attachment #1.1: Type: text/plain, Size: 1395 bytes --]
Edvard Majakari writes:
Edvard> Can I somehow make smiley.el parse regexps case-sensitively? The
Edvard> package is great but it seems like it sees ':-D' as ':-d' - which
Edvard> is quite a different thing :->
Edvard> -- Ed GSM: 040 5960810 URL: http://lodge.ton.tut.fi/%7Eed/
Edvard> And so there remain Faith, Hope, Love--these three; and of these
Edvard> the greatest is Love. 1st Cor. 13:13
I have created a patch to fix that and now smiley is case-sensitive. With
it, you will see that :-D is different from :-d
This patch is based on 5.4.64.
Lars, can you apply to patch to the next release (5.4.67)?
Thanks,
--
^..^
'/..\" ( oo ) )~
m( oo )m ,, ,,
/=-=-=-=-=-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=\
| Danny Dick-Fung Siu http://www-leland.stanford.edu/~dsiu |
| Reference System Group http://www.csua.berkeley.edu/~dsiu |
| Adobe Systems Incorporated E-Mail:<dsiu@alumni.eecs.berkeley.edu> |
| "What do you expect from a <dsiu@leland.stanford.edu> |
| Cal. Berkeley grad.?" <dsiu@adobe.com> |
\=-=-=-=-=-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=/
[-- Attachment #1.2: smiley.patch --]
[-- Type: application/octet-stream, Size: 3943 bytes --]
diff -C5 lisp/ChangeLog lisp-new/ChangeLog
*** lisp/ChangeLog Sat Jul 19 14:39:22 1997
--- lisp-new/ChangeLog Wed Jul 30 09:34:44 1997
***************
*** 1,5 ****
--- 1,12 ----
+ Wed Jul 30 09:37:28 1997 Danny Siu <dsiu@adobe.com>
+
+ * smiley.el (smiley-buffer): make smiley case sensitive
+ (smiley-deformed-regexp-alist): fixed smiley regexp where case is
+ insensitive
+ (smiley-nosey-regexp-alist): same as above
+
Sat Jul 19 23:32:28 1997 Lars Magne Ingebrigtsen <larsi@menja.ifi.uio.no>
* gnus.el: Gnus v5.4.64 is released.
Sat Jul 19 23:22:03 1997 Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
Only in lisp-new: ChangeLog~
diff -C5 lisp/smiley.el lisp-new/smiley.el
*** lisp/smiley.el Wed Jun 18 08:31:43 1997
--- lisp-new/smiley.el Wed Jul 30 09:31:19 1997
***************
*** 67,81 ****
("\\([8|]-*[|Oo%]\\)\\W" 1 "FaceKOed.xpm")
("\\([:|]-*#+\\)\\W" 1 "FaceNyah.xpm")
("\\(:-*[({]+\\)\\W" 1 "FaceSad.xpm")
("\\(:-*[Oo\*]\\)\\W" 1 "FaceStartled.xpm")
("\\(:-*|\\)\\W" 1 "FaceStraight.xpm")
! ("\\(:-*p\\)\\W" 1 "FaceTalking.xpm")
("\\(:-*d\\)\\W" 1 "FaceTasty.xpm")
("\\(;-*[>)}»]+\\)\\W" 1 "FaceWinking.xpm")
("\\(:-*[Vvµ]\\)\\W" 1 "FaceWry.xpm")
! ("\\([:|]-*P\\)\\W" 1 "FaceYukky.xpm"))
"Normal and deformed faces for smilies."
:type '(repeat (list regexp
(integer :tag "Match")
(string :tag "Image")))
:group 'smiley)
--- 67,81 ----
("\\([8|]-*[|Oo%]\\)\\W" 1 "FaceKOed.xpm")
("\\([:|]-*#+\\)\\W" 1 "FaceNyah.xpm")
("\\(:-*[({]+\\)\\W" 1 "FaceSad.xpm")
("\\(:-*[Oo\*]\\)\\W" 1 "FaceStartled.xpm")
("\\(:-*|\\)\\W" 1 "FaceStraight.xpm")
! ("\\(:-*[Pp]\\)\\W" 1 "FaceTalking.xpm")
("\\(:-*d\\)\\W" 1 "FaceTasty.xpm")
("\\(;-*[>)}»]+\\)\\W" 1 "FaceWinking.xpm")
("\\(:-*[Vvµ]\\)\\W" 1 "FaceWry.xpm")
! ("\\([:|]-*[Pp]\\)\\W" 1 "FaceYukky.xpm"))
"Normal and deformed faces for smilies."
:type '(repeat (list regexp
(integer :tag "Match")
(string :tag "Image")))
:group 'smiley)
***************
*** 90,105 ****
("\\([8|]-+[|Oo%]\\)\\W" 1 "FaceKOed.xpm")
("\\([:|]-+#+\\)\\W" 1 "FaceNyah.xpm")
("\\(:-+[({]+\\)\\W" 1 "FaceSad.xpm")
("\\(:-+[Oo\*]\\)\\W" 1 "FaceStartled.xpm")
("\\(:-+|\\)\\W" 1 "FaceStraight.xpm")
! ("\\(:-+p\\)\\W" 1 "FaceTalking.xpm")
("\\(:-+d\\)\\W" 1 "FaceTasty.xpm")
("\\(;-+[>)}»]+\\)\\W" 1 "FaceWinking.xpm")
("\\(:-+[Vvµ]\\)\\W" 1 "FaceWry.xpm")
("\\(][:8B]-[)>]\\)\\W" 1 "FaceDevilish.xpm")
! ("\\([:|]-+P\\)\\W" 1 "FaceYukky.xpm"))
"Smileys with noses. These get less false matches."
:type '(repeat (list regexp
(integer :tag "Match")
(string :tag "Image")))
:group 'smiley)
--- 90,105 ----
("\\([8|]-+[|Oo%]\\)\\W" 1 "FaceKOed.xpm")
("\\([:|]-+#+\\)\\W" 1 "FaceNyah.xpm")
("\\(:-+[({]+\\)\\W" 1 "FaceSad.xpm")
("\\(:-+[Oo\*]\\)\\W" 1 "FaceStartled.xpm")
("\\(:-+|\\)\\W" 1 "FaceStraight.xpm")
! ("\\(:-+[Pp]\\)\\W" 1 "FaceTalking.xpm")
("\\(:-+d\\)\\W" 1 "FaceTasty.xpm")
("\\(;-+[>)}»]+\\)\\W" 1 "FaceWinking.xpm")
("\\(:-+[Vvµ]\\)\\W" 1 "FaceWry.xpm")
("\\(][:8B]-[)>]\\)\\W" 1 "FaceDevilish.xpm")
! ("\\([:|]-+[Pp]\\)\\W" 1 "FaceYukky.xpm"))
"Smileys with noses. These get less false matches."
:type '(repeat (list regexp
(integer :tag "Match")
(string :tag "Image")))
:group 'smiley)
***************
*** 206,215 ****
--- 206,216 ----
(set-buffer buffer))
(let ((buffer-read-only nil)
(alist (if (symbolp smiley-regexp-alist)
(symbol-value smiley-regexp-alist)
smiley-regexp-alist))
+ (case-fold-search nil)
entry regexp beg group file)
(goto-char (or st (point-min)))
(setq beg (point))
;; loop through alist
(while (setq entry (pop alist))
[-- Attachment #2: Type: application/pgp-signature, Size: 344 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread