* Re: Compile warnings
2002-04-23 8:52 Compile warnings Pavel Janík
@ 2002-04-24 7:42 ` Katsumi Yamaoka
2002-04-27 17:53 ` ShengHuo ZHU
0 siblings, 1 reply; 3+ messages in thread
From: Katsumi Yamaoka @ 2002-04-24 7:42 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
Hi,
>>>>> In <m33cxmhk4r.fsf@Janik.cz>
>>>>> Pavel@Janik.cz (Pavel Janík) wrote:
Pavel> While compiling current CVS gnus with current CVS Emacs, I've got:
Pavel> /home/pavel/.Emacs/Work/gnus/lisp/dns.el: In query-dns
Pavel> /home/pavel/.Emacs/Work/gnus/lisp/dns.el:282: warning: open-network-stream called with 5 arguments, but accepts only 4
Here's one solution attached below, but I haven't confirmed it
completely because I don't have the function `make-network-process'.
Pavel> /home/pavel/.Emacs/Work/gnus/lisp/gnus-msg.el: In gnus-summary-reply
Pavel> /home/pavel/.Emacs/Work/gnus/lisp/gnus-msg.el:971: warning: reference to free variable article-buffer
I've got the same warn, but no ideas.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dns.el.diff --]
[-- Type: text/x-patch, Size: 3333 bytes --]
--- dns.el~ 2002-03-31 16:36:22.000000000 +0000
+++ dns.el 2002-04-24 07:41:30.000000000 +0000
@@ -280,6 +280,24 @@
;;; Interface functions.
+(defmacro dns-make-network-process (server)
+ (if (featurep 'xemacs)
+ `(let ((coding-system-for-read 'binary)
+ (coding-system-for-write 'binary))
+ (open-network-stream "dns" (current-buffer) ,server "domain" 'udp))
+ `(let ((server ,server)
+ (coding-system-for-read 'binary)
+ (coding-system-for-write 'binary))
+ (if (fboundp 'make-network-process)
+ (make-network-process
+ :name "dns"
+ :coding 'binary
+ :buffer (current-buffer)
+ :host server
+ :service "domain"
+ :type 'datagram)
+ (open-network-stream "dns" (current-buffer) server "domain")))))
+
(defun query-dns (name &optional type fullp)
"Query a DNS server for NAME of TYPE.
If FULLP, return the entire record returned."
@@ -289,53 +307,36 @@
(unless dns-servers
(error "No DNS server configuration found")))
(mm-with-unibyte-buffer
- (let ((coding-system-for-read 'binary)
- (coding-system-for-write 'binary)
- (tcp-p (and (not (fboundp 'open-network-stream))
- (not (featurep 'xemacs)))))
- (let ((process
- (cond
- ((featurep 'xemacs)
- (open-network-stream
- "dns" (current-buffer) (car dns-servers) "domain" 'udp))
- (tcp-p
- (open-network-stream
- "dns" (current-buffer) (car dns-servers) "domain"))
- (t
- (make-network-process
- :name "dns"
- :coding 'binary
- :buffer (current-buffer)
- :host (car dns-servers)
- :service "domain"
- :type 'datagram))))
- (step 100)
- (times (* dns-timeout 1000))
- (id (random 65000)))
- (process-send-string
- process
- (dns-write `((id ,id)
- (opcode query)
- (queries ((,name (type ,type))))
- (recursion-desired-p t))
- tcp-p))
- (while (and (zerop (buffer-size))
- (> times 0))
- (accept-process-output process 0 step)
- (decf times step))
- (ignore-errors
- (delete-process process))
- (when tcp-p
- (goto-char (point-min))
- (delete-region (point) (+ (point) 2)))
- (unless (zerop (buffer-size))
- (let ((result (dns-read (buffer-string))))
- (if fullp
- result
- (let ((answer (car (dns-get 'answers result))))
- (when (eq type (dns-get 'type answer))
- (dns-get 'data answer))))))))))
-
+ (let ((process (dns-make-network-process (car dns-servers)))
+ (tcp-p (and (not (fboundp 'make-network-process))
+ (not (featurep 'xemacs))))
+ (step 100)
+ (times (* dns-timeout 1000))
+ (id (random 65000)))
+ (process-send-string
+ process
+ (dns-write `((id ,id)
+ (opcode query)
+ (queries ((,name (type ,type))))
+ (recursion-desired-p t))
+ tcp-p))
+ (while (and (zerop (buffer-size))
+ (> times 0))
+ (accept-process-output process 0 step)
+ (decf times step))
+ (ignore-errors
+ (delete-process process))
+ (when tcp-p
+ (goto-char (point-min))
+ (delete-region (point) (+ (point) 2)))
+ (unless (zerop (buffer-size))
+ (let ((result (dns-read (buffer-string))))
+ (if fullp
+ result
+ (let ((answer (car (dns-get 'answers result))))
+ (when (eq type (dns-get 'type answer))
+ (dns-get 'data answer)))))))))
+
(provide 'dns)
;;; dns.el ends here
^ permalink raw reply [flat|nested] 3+ messages in thread