From: Adam Thompson <arthompson1990@gmail.com>
To: Karl Dahlke <eklhad@comcast.net>
Cc: Edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] this
Date: Tue, 24 Dec 2013 18:09:11 +0000 [thread overview]
Message-ID: <20131224180911.GE18259@toaster.adamthompson.me.uk> (raw)
In-Reply-To: <20131124120024.eklhad@comcast.net>
On Tue, Dec 24, 2013 at 12:00:24PM -0500, Karl Dahlke wrote:
> chris is right about this,
> I use it as a variable several times in jsdom.c.
> But we don't want to just
>
> ,s/this/t/g
>
> because this appears as an english word in quite a few comments.
> So we just have to step through and replace with care.
> Adam do you want to do this while you are in looking at other things,
> or do you want me to replace and push?
> Your call.
Already done in the jsdom.cpp I sent.
I used obj rather than this.
This also depends on a change in eb.p as well,
but I can send that once we're happy the c++ js* files are ok.
I also had to alter several uses of class into objClass (not sure if you prefer
objClass or obj_class, based on the function naming I chose the former,
though I'd probably prefer the latter).
I also think I know why you stopped using void * for js stuff,
the massive amount of casting involved.
Oh well.
Cheers,
Adam.
PS: we probably want to condense some of the casting into a JSObject *obj =
(JSObject *whatever) but I just went through the file with the intent of
getting it to build. I can do cleanup once things are somewhere near working.
next prev parent reply other threads:[~2013-12-24 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 17:00 Karl Dahlke
2013-12-24 18:09 ` Adam Thompson [this message]
2013-12-24 18:21 ` Adam Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131224180911.GE18259@toaster.adamthompson.me.uk \
--to=arthompson1990@gmail.com \
--cc=Edbrowse-dev@lists.the-brannons.com \
--cc=eklhad@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).