From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] my_ErrorReporter
Date: Fri, 24 Jan 2014 07:13:20 -0500 [thread overview]
Message-ID: <20140024071320.eklhad@comcast.net> (raw)
Looks very much the same in Adam's latest as in mine.
A small change, just to be safe, make the last line
if(report) report->flags = 0;
This function uses JS-smprintf and JS_free,
and these are only used one other place in jsloc.c,
and I don't get why the sprintf call doesn't need the js context,
but the corresponding free call does.
That just makes me nervous.
No I don't think that's any of our bug problems so far,
but it's something we should address before a stable release.
And the funny thing is, JS_smprintf is almost pointless in the C++ world,
just concatenate the strings together and C++ will manage everything.
And in my_ErrorReporter we could even use cerr directly.
So might be we don't even need the silly function,
I'm just saying I don't quite understand it.
As you see from this, I finally cloned your code.
I plan to read through it first, then find / install moz 24,
then build and play.
Karl Dahlke
next reply other threads:[~2014-01-24 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 12:13 Karl Dahlke [this message]
2014-01-24 19:08 ` Adam Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140024071320.eklhad@comcast.net \
--to=eklhad@comcast.net \
--cc=Edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).