edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] Chris patch is in
Date: Sun, 02 Feb 2014 20:18:59 -0500	[thread overview]
Message-ID: <20140102201859.eklhad@comcast.net> (raw)

Well my question of a few days ago,
why not make a vector of structs and really use the power of c++,
instead of a list of pointers to structs that I still have to allocate,
well I now know the answer, after wasting a couple days of programming
and debugging.
I should have known from the get-go.
If the struct itself moves, because of realloc, all the pointers that use
to point to it are invalid, and to try to keep up with that
is an impossible bookkeeping nightmare.
So Chris was right, keep it simple, just use a list
of pointers to the structures that I already allocate,
and the structures don't move, and they can point to each other,
and all is well.

I built and tested and pushed his patch.
We can in the future replace tagArray with a c++ array or vector,
if that makes sense,
but not a big hurry on that.

While testing I uncovered a bug, and I thought I caused it,
or maybe Chris patch caused it, but no, it was there before.
Run edbrowse with this as input.

e jsrt
b
3g
$i3*
y
/colors
qt

The form starts out with colors green and white,
which are by the way the colors of the Michigan State Spartans,
who won the Rose Bowl, thank you very much.
But after reset the colors blank out,
and they should default back to green and white.
This bug only happens with 3g, which pushes the javascript timer button.
So next I'll try to track down this bug.
But since it was there before, not caused by what Chris and I did,
I pushed our change.

Karl Dahlke

                 reply	other threads:[~2014-02-03  1:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140102201859.eklhad@comcast.net \
    --to=eklhad@comcast.net \
    --cc=Edbrowse-dev@lists.the-brannons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).