[Edbrowse-dev] warnings in url.c

[Edbrowse-dev] warnings in url.c

[Karl Dahlke]

> size_t variables (which we really need to be using for portability),

Yes, some day, but that is a systemic change
that I'm not ready to make at this time.
For today, and for consistency,
change outPathLen to int and I'm pretty sure all will work.

Karl Dahlke

[Edbrowse-dev] warnings in url.c

[Adam Thompson]

Hi,

Following the indent I rebuilt on both 64 and 32 bit machines.
On 32 bit all is fine, but on 64 bit I get the warnings I mentioned before.

These warnings look like:
url.c:551:2: warning: passing argument 1 of ���initString��� from incompatible per type [enabled by default]
  outPath = initString(&outPathLen);
  ^
In file included from eb.h:380:0,
                 from url.c:8:
eb.p:194:7: note: expected ���int *��� but argument is of type ���size_t *��
� char *initString(int *l);

This is because we're using functions which return size_t (64 bits on amd64
with gcc) and passing that to a function which expects an int (32 bits on amd64 with gcc).
Looking through stringfile.c I see lots of these functions,
with the stringAnd* functions using bit operations to (I think)
work out the reallocation amounts. I can sit down and work out if this math
will still work on size_t variables (which we really need to be using for
portability), however would it be possible for someone (Karl)
to explain what the logic really should be?
Also why is this being done with bit operations? Performance?

Cheers,
Adam.