* [Edbrowse-dev] one more necessary big change
@ 2014-02-06 15:36 Karl Dahlke
0 siblings, 0 replies; 3+ messages in thread
From: Karl Dahlke @ 2014-02-06 15:36 UTC (permalink / raw)
To: Edbrowse-dev
Well I would call this a bug fix, not a big change,
but maybe that's just a subjective distinction.
If you mean things like jsloc.cpp
loc_toString()
line 94
jsval rval;
Making that and others rooted, then that's fine, go ahead and push
and I'll just look at the log diff later.
If it's something different then let us know.
Thanks.
Karl Dahlke
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Edbrowse-dev] one more necessary big change
2014-02-06 15:14 Chris Brannon
@ 2014-02-06 17:57 ` Adam Thompson
0 siblings, 0 replies; 3+ messages in thread
From: Adam Thompson @ 2014-02-06 17:57 UTC (permalink / raw)
To: Chris Brannon; +Cc: edbrowse-dev
On Thu, Feb 06, 2014 at 07:14:31AM -0800, Chris Brannon wrote:
> I still see lots of places where we're using raw JSVAL *, and these need
> to be changed to use JS::RootedValue.
> I'll do it today. I can post the patch for review, or just push it,
> whichever you guys prefer.
Go ahead and push, just let us know when it's pushed.
We can always look at the diff later.
Cheers,
Adam.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Edbrowse-dev] one more necessary big change
@ 2014-02-06 15:14 Chris Brannon
2014-02-06 17:57 ` Adam Thompson
0 siblings, 1 reply; 3+ messages in thread
From: Chris Brannon @ 2014-02-06 15:14 UTC (permalink / raw)
To: edbrowse-dev
I still see lots of places where we're using raw JSVAL *, and these need
to be changed to use JS::RootedValue.
I'll do it today. I can post the patch for review, or just push it,
whichever you guys prefer.
-- Chris
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-06 17:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-06 15:36 [Edbrowse-dev] one more necessary big change Karl Dahlke
-- strict thread matches above, loose matches on Subject: below --
2014-02-06 15:14 Chris Brannon
2014-02-06 17:57 ` Adam Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).