[Edbrowse-dev] simpler html.cpp

[Edbrowse-dev] simpler html.cpp

[Karl Dahlke]

As portended by my earlier email, all the rooted variables are gone.
All the AutoCompartments are gone.
They were just local variables as shorthand for objects
that were already put on the rooted heap and tied to tags.

The functions in html.cpp now run, I believe, properly
whether cw->jss is null or not.
And to test this, there is now a way for jss to be null.
Disable javascript, with the js command or through the
nojs directive in your config file, then browse.
The java state isn't even created.
Part of my regression test is now to run jsrt through its paces,
with javascript and without javascript.

Next step, I will allow CreateContext() to fail, if it does fail,
without exiting, and leave jss null.
Then once this is working we can set up other error legs.

Karl Dahlke

Re: [Edbrowse-dev] simpler html.cpp

[Adam Thompson]

On Tue, Feb 11, 2014 at 12:28:36AM -0500, Karl Dahlke wrote:
> As portended by my earlier email, all the rooted variables are gone.
> All the AutoCompartments are gone.
> They were just local variables as shorthand for objects
> that were already put on the rooted heap and tied to tags.

Sounds good, that code's been on my to review list for a while.
Will pull and test later today.

> Disable javascript, with the js command or through the
> nojs directive in your config file, then browse.
> The java state isn't even created.

That's nice to hear.

> Part of my regression test is now to run jsrt through its paces,
> with javascript and without javascript.

Sounds sensible. Any way to make jsrt test the gc a bit more?

> Next step, I will allow CreateContext() to fail, if it does fail,
> without exiting, and leave jss null.
> Then once this is working we can set up other error legs.

Yeah, again sounds sensible.

Cheers,
Adam.