From: Adam Thompson <arthompson1990@gmail.com>
To: Karl Dahlke <eklhad@comcast.net>
Cc: Edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] AutoCompartment other window
Date: Tue, 11 Feb 2014 15:41:23 +0000 [thread overview]
Message-ID: <20140211154123.GP11542@toaster.adamthompson.me.uk> (raw)
In-Reply-To: <20140111065522.eklhad@comcast.net>
On Tue, Feb 11, 2014 at 06:55:22AM -0500, Karl Dahlke wrote:
> A question for you in jsdom.cpp function domLink().
> This line
>
> JS::RootedObject owner_root(cw->jss->jcx, owner);
>
> Then you use owner_root instead of owner thereafter.
> Is this necessary?
> owner is safely rooted on the heap and isn't going to go anywhere.
> We could just use owner throughout and it would be much clearer.
That's from when the html parser wasn't js-aware,
I've just pushed a change rectifying this (removing owner_root).
Cheers,
Adam.
prev parent reply other threads:[~2014-02-11 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 11:55 Karl Dahlke
2014-02-11 15:41 ` Adam Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211154123.GP11542@toaster.adamthompson.me.uk \
--to=arthompson1990@gmail.com \
--cc=Edbrowse-dev@lists.the-brannons.com \
--cc=eklhad@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).