[Edbrowse-dev] [PATCH] Implement the "novs" directive.

[Karl Dahlke <eklhad@comcast.net>]

This looks good.
You could submit it and I would be fine with that.

I do have a couple small questions though.
The first is just style / consistency.
You use strcasecmp for I guess string compare case insensitive.
A library function I didn't know about?
I use throughout stringEqualCI, which I wrote myself.
Should we always use one, or the other?
Mine is part of a suite of such CI functions, like mem compare CI and so on,
I'm sure not all have library equivalents.

You took the time to add sites in a growing dynamic list,
which is right, sometimes I was too lazy to do that.
Like nojs, I store 100 sites for no javascript and that's it.
Any time you, or I, feel like making this dynamic, feel free.
Same for email accounts, though I can't imagine anyone having
more than 100 of those.
And maybe other static lists floating around.

When you check for novs match you need an exact match.
Not so for nojs.
whatever.com will also have no javascript for subdomains
like foo.whatever.com.
See the code in main.c that does that.
Should we do the same for novs?
I would think so; if there's no cert for whatever.com
then there is for sure no cert for foo.whatever.com.


Karl Dahlke