From: Karl Dahlke <eklhad@comcast.net>
To: edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] 3.6.0?
Date: Wed, 02 Dec 2015 23:52:29 -0500 [thread overview]
Message-ID: <20151102235229.eklhad@comcast.net> (raw)
In-Reply-To: <alpine.LRH.2.03.1512021845200.14800@carhart.net>
Ok, this is good.
Kevin I installed your latest patch, tested jsrt etc,
and then pushed it to Master,
but I don't think removeEventListener is quite right.
I'm too tired to look at it now but I'll review it tomorrow.
I think you want to compare the passed in function, just as a function,
with the functions in the array, and if found use splice to remove it,
or if it matches the original function then remove that,
or do nothing if it doesn't match any of these.
I doubt you want to expand both functions back into source and compare those,
but hey I'm not sure.
So on we go.
Karl Dahlke
next prev parent reply other threads:[~2015-12-03 4:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 18:11 Chris Brannon
2015-12-02 20:01 ` Karl Dahlke
2015-12-03 1:59 ` Kevin Carhart
2015-12-03 2:42 ` Chris Brannon
2015-12-03 3:13 ` Kevin Carhart
2015-12-03 4:52 ` Karl Dahlke [this message]
2015-12-04 1:05 ` Kevin Carhart
2015-12-04 14:24 ` Karl Dahlke
2015-12-04 21:10 ` [Edbrowse-dev] jquery v2 and an interesting seg fault Kevin Carhart
2015-12-04 22:11 ` Karl Dahlke
2015-12-04 22:28 ` Kevin Carhart
2015-12-05 9:12 ` [Edbrowse-dev] javascript() in timer side effects Kevin Carhart
2015-12-05 14:39 ` Karl Dahlke
2015-12-06 0:19 ` Kevin Carhart
2015-12-06 0:26 ` Karl Dahlke
2015-12-06 2:48 ` Kevin Carhart
2015-12-06 11:38 ` Adam Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102235229.eklhad@comcast.net \
--to=eklhad@comcast.net \
--cc=edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).