edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Adam Thompson <arthompson1990@gmail.com>
To: Karl Dahlke <eklhad@comcast.net>
Cc: Edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] segfault in latest Edbrowse
Date: Sat, 6 Feb 2016 12:03:17 +0000	[thread overview]
Message-ID: <20160206120317.GB9038@122oven.adamthompson.me.uk> (raw)
In-Reply-To: <20160105085922.eklhad@comcast.net>

[-- Attachment #1: Type: text/plain, Size: 1789 bytes --]

On Fri, Feb 05, 2016 at 08:59:22AM -0500, Karl Dahlke wrote:
> Fixed by last push.

Thanks, I can confirm this works.

> The problem here was me trying to work around the <A><DIV> tidy bug,
> illustrated by:
> http://www.eklhad.net/div
> My tree rearranger worked most of the time, particularly in facebook,
> cleaned a lot of things up,
> but it found a false positive somewhere in stackoverflow,
> fixed a tree that didn't need fixing, thus breaking the tree,
> and that led to all the problems.

Ah ok, I wondered if it was that change but didn't have the time to check.

> So I commented out the routine for now,
> and stackoverflow works again, and facebook is back to being a little clunky.
> In general, if you see
> 
> {} farm animals
> 
> It could likely mean {farm animals},
> and you should click on the empty braces to see.

Yeah, I'm not sure how much of a bug this is exactly,
I think there's some odd interactions here which I'm not that sure about.

> The moral if there is one is to be wary of trying to work around things
> via html preprocessing code or tree postprocessing code.
> Unless a bug really derails pages (which has happened in the past),
> I should probably exercise patience, because tidy always catches up.

Yeah. Or we can fix in rendering possibly?
That's what's really going on here if I understand the bug correctly.
the Blank braces then text sound like a construct I've seen recommended by
various (unspecified) web developers to get "clickable" divs.
Since the text isn't actually in the link it's not contained in the node.
I think what most browsers do is render this as a link without actually
altering the DOM (because that'd be wrong).
I'm not sure if this is the same problem though.

Cheers,
Adam.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

      parent reply	other threads:[~2016-02-06 12:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04 20:37 Adam Thompson
2016-02-05  5:28 ` Karl Dahlke
2016-02-05  6:47 ` Chris Brannon
2016-02-05  9:25 ` Chris Brannon
2016-02-05 13:59 ` Karl Dahlke
2016-02-05 14:21   ` Geoff McLane
2016-02-06 11:57     ` Adam Thompson
2016-02-06 12:03   ` Adam Thompson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160206120317.GB9038@122oven.adamthompson.me.uk \
    --to=arthompson1990@gmail.com \
    --cc=Edbrowse-dev@lists.the-brannons.com \
    --cc=eklhad@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).