From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] document.removeAttribute
Date: Tue, 24 Jan 2017 15:48:49 -0500 [thread overview]
Message-ID: <20170024154849.eklhad@comcast.net> (raw)
In-Reply-To: <20170124190824.GA6334@odin>
I'm a bit confused.
It all works if you remove an attribute that is there,
but if you remove an attribute that isn't there ...
startwindow.js line 233
c.attributes = new Object;
Not an array but an object.
So if c doesn't have foo then you try to get attributes.length
like it's an array but it's not, so I think that would fail and stop js right there.
Same problem for hasAttribute etc.
Look at decorate.c line 825.
There I make attributes an array.
I think maybe startwindow.js should read
c.attributes = new Array;
That would be consistent.
If so then it's my bug, sorry.
What say you.
Karl Dahlke
next prev parent reply other threads:[~2017-01-24 20:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 20:04 Adam Thompson
2017-01-19 20:32 ` Chris Brannon
2017-01-19 21:34 ` Kevin Carhart
2017-01-24 8:43 ` Adam Thompson
2017-01-24 19:08 ` Adam Thompson
2017-01-24 20:48 ` Karl Dahlke [this message]
2017-01-24 22:08 ` Kevin Carhart
[not found] ` <20170024174651.eklhad@comcast.net>
2017-01-24 23:57 ` Kevin Carhart
2017-01-25 1:50 ` Karl Dahlke
2017-01-21 0:27 ` Karl Dahlke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170024154849.eklhad@comcast.net \
--to=eklhad@comcast.net \
--cc=Edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).