From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] Windows MSVC140 build
Date: Fri, 27 Jan 2017 14:21:49 -0500 [thread overview]
Message-ID: <20170027142149.eklhad@comcast.net> (raw)
In-Reply-To: <a9a9dec2-c5d9-1984-6f11-9a789ec09163@geoffair.info>
> The two main ones are in jseng-moz.cpp... in the function
> 1. Why is 'ssize_t rc;' used, instead of just 'int rc;'?
Because the manual page for read() says it returns type size_t.
Implicitly casting that into an int, as in int rc, is no trouble so make that change if you wish.
We're not going to be reading more than 2 gig at a shot.
> 2. Why is '(short unsigned int *)uc_run' used instead
> of '(const jschar *)uc_run'?
don't know - I went for the actual type, but that's platform specific,
so go ahead and use jschar * instead, it works.
Karl Dahlke
next prev parent reply other threads:[~2017-01-27 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 19:02 Geoff McLane
2017-01-27 19:21 ` Karl Dahlke [this message]
2017-01-27 19:43 ` Geoff McLane
2017-01-27 19:59 ` Karl Dahlke
2017-01-28 2:06 ` Geoff McLane
2017-01-28 2:36 ` Karl Dahlke
2017-01-28 16:53 ` Geoff McLane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170027142149.eklhad@comcast.net \
--to=eklhad@comcast.net \
--cc=Edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).