From: Geoff McLane <ubuntu@geoffair.info>
To: edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] Windows MSVC140 build
Date: Sat, 28 Jan 2017 17:53:45 +0100 [thread overview]
Message-ID: <34c003c6-c323-2add-dc15-e268eed6a6de@geoffair.info> (raw)
In-Reply-To: <20170027213623.eklhad@comcast.net>
Yes, I think I still have push access to your repo,
but over recent years have got into the habit of
changing, testing only in a forked branch...
And then when I am happy with the results, present
a Pull Request, which I then complete if I also have
access to the upstream master, like in this case...
It is just a few more git steps... so will do this when
tested...
>> not sure I understood the use of 'ftruncate' in the second case...
> It should have been cacheControl, a bug, I have fixed it now.
Ok, understand you are just developing the cache code,
and at this stage my changes were only to get a WIN32
msvc140 error free compile...
So I will continue in this just-fix-to-compile mode until you
actually 'connect' to the cache.c code, and want the
results tested, and working in windows...
And yes, I did carefully check where you are putting this in
Windows, and noted that you have used the TEMP environment
variable to locate this, and that is fine and correct in Windows...
And understand the unix philosophy of using ~/.ebcache is
quite different...
So this seems all correct to me, and thanks for taking the effort
to get it right for windows...
Regards, Geoff.
prev parent reply other threads:[~2017-01-28 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 19:02 Geoff McLane
2017-01-27 19:21 ` Karl Dahlke
2017-01-27 19:43 ` Geoff McLane
2017-01-27 19:59 ` Karl Dahlke
2017-01-28 2:06 ` Geoff McLane
2017-01-28 2:36 ` Karl Dahlke
2017-01-28 16:53 ` Geoff McLane [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34c003c6-c323-2add-dc15-e268eed6a6de@geoffair.info \
--to=ubuntu@geoffair.info \
--cc=edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).