From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] defaultView and getComputedStyle patch
Date: Mon, 14 Aug 2017 02:35:52 -0400 [thread overview]
Message-ID: <20170714023552.eklhad@comcast.net> (raw)
In-Reply-To: <20170713214236.kevin@carhart.net >
I went ahead and pushed this patch because it does no harm and moves you forward, but it still confuses me.
Your getComputedStyle function at line 759 is equivalent to
function getComputedStyle(e, p) { return e.style; }
The obj variable is local and goes away when the function returns.
So why not write it my way it's a whole lot easier to understand. Unless I'm missing something.
Karl Dahlke
next prev parent reply other threads:[~2017-08-14 6:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 4:42 Kevin Carhart
2017-08-14 6:35 ` Karl Dahlke [this message]
2017-08-15 0:48 ` Kevin Carhart
2017-08-15 1:26 ` Karl Dahlke
2017-08-15 3:05 ` Kevin Carhart
[not found] ` <20170715003928.eklhad@comcast.net>
2017-08-15 5:38 ` Kevin Carhart
2017-08-15 6:43 ` Karl Dahlke
2017-08-15 7:08 ` Kevin Carhart
2017-08-15 7:33 ` Kevin Carhart
2017-08-15 8:33 ` Karl Dahlke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714023552.eklhad@comcast.net \
--to=eklhad@comcast.net \
--cc=Edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).