edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Karl Dahlke <eklhad@comcast.net>
To: edbrowse-dev@edbrowse.org
Subject: can we quit patching quickjs?
Date: Tue, 16 Aug 2022 19:40:49 -0400	[thread overview]
Message-ID: <20220716194049.eklhad@comcast.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

Folks, I had a clever, and somewhat frightening, and somewhat ugly thought, but no uglier that patching and building quickjs ourselves.
I can enqueue a job manually, just as promise does, then scan the runtime structure to see what has changed.
This is, hopefully, the location of the jobs queue.
The commit is 42d5b695989a9dc92dc66a7de6f92176d2e0a0de
Look at it as a patch file and see what I did.
I encourage you brave souls to try it out.
If we all decide it works, and is safe, then we can delete tools/quickjobfixup, and remove all  those instructions about patching and building quick from source,
and just link to the quick package, if one is distributed and available.
Of course if there is no quick package, and there often isn't, the user or the package manager can still build quick from source, but he doesn't have to patch it.

I don't know why I didn't think of this sooner.

Comments welcome.

Karl Dahlke

             reply	other threads:[~2022-08-16 23:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16 23:40 Karl Dahlke [this message]
2022-08-17  0:28 ` Dominique Martinet
2022-08-17  0:43   ` Karl Dahlke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220716194049.eklhad@comcast.net \
    --to=eklhad@comcast.net \
    --cc=edbrowse-dev@edbrowse.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).