From: Chris Brannon <chris@the-brannons.com>
To: edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] garbage collection
Date: Thu, 23 Jan 2014 12:27:10 -0800 [thread overview]
Message-ID: <87lhy6qw9t.fsf@mushroom.PK5001Z> (raw)
I'm more and more convinced that the JavaScript crashes are related to
GC and rooting, as Adam suspected. The crashes I'm seeing are occurring
in jsdom.c, and they seem to involve corruption of the JS heap, not the
heap used for edbrowse strings and other data.
Example: this one at line 1185 of jsdom.c from master:
v = JS_NewObject(jcx, cp, NULL, owner);
One of the pointers passed in is apparently pointing to something that
was freed long ago. I don't think it's jcx or cp, so it must be owner.
So let's switch gears. I've been working with Adam's code, and it still
has GC / rooting issues. From what I can tell, JS_DefineProperty can
trigger a GC. We should not be passing unrooted jsval as the fourth
argument to JS_DefineProperty as this can also lead to a crash.
Also there seems to be a problem in jsloc.cpp, caused by uo, which is a
statically allocated pointer to a JS object that is never rooted.
-- Chris
next reply other threads:[~2014-01-23 20:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 20:27 Chris Brannon [this message]
2014-01-24 10:59 ` [Edbrowse-dev] garbage collection1 Adam Thompson
2014-01-24 14:21 ` Chris Brannon
2014-01-24 14:58 ` Adam Thompson
2014-01-24 22:07 ` Chris Brannon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhy6qw9t.fsf@mushroom.PK5001Z \
--to=chris@the-brannons.com \
--cc=edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).