From: Adam Thompson <arthompson1990@gmail.com>
To: Chris Brannon <chris@the-brannons.com>
Cc: edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] garbage collection1
Date: Fri, 24 Jan 2014 14:58:33 +0000 [thread overview]
Message-ID: <20140124145833.GE12450@toaster.adamthompson.me.uk> (raw)
In-Reply-To: <878uu5qx3y.fsf@mushroom.PK5001Z>
On Fri, Jan 24, 2014 at 06:21:21AM -0800, Chris Brannon wrote:
> Adam Thompson <arthompson1990@gmail.com> writes:
>
> >> We should not be passing unrooted jsval as the fourth
> >> argument to JS_DefineProperty as this can also lead to a crash.
> >
> > Yeah, I'm not sure how to work around this.
>
> I am, and a patch is attached. There may be other cases. I can look through
> the code for them. I fixed the one I noticed.
Ah, ok, I see what you mean. I've looked through and *hopefully* fixed a bunch of them.
I've definitely pushed the set of commits now (git push origin master)
so hoefully you can see them.
In addition I think we need to change the establish_property_* functions to take
JS::Handle and js::MutableHandle arguments.
Cheers,
Adam.
next prev parent reply other threads:[~2014-01-24 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 20:27 [Edbrowse-dev] garbage collection Chris Brannon
2014-01-24 10:59 ` [Edbrowse-dev] garbage collection1 Adam Thompson
2014-01-24 14:21 ` Chris Brannon
2014-01-24 14:58 ` Adam Thompson [this message]
2014-01-24 22:07 ` Chris Brannon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140124145833.GE12450@toaster.adamthompson.me.uk \
--to=arthompson1990@gmail.com \
--cc=chris@the-brannons.com \
--cc=edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).