edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
* [Edbrowse-dev]  subdomain match
@ 2014-09-13 15:18 Karl Dahlke
  2014-09-13 15:39 ` Chris Brannon
  0 siblings, 1 reply; 4+ messages in thread
From: Karl Dahlke @ 2014-09-13 15:18 UTC (permalink / raw)
  To: Edbrowse-dev

No need to resend; that was my only question of any substance.
Go ahead and push, and I'll pull and give it a whirl.
This will make vs and novs just like js and nojs, so that's better.
I do indeed have a couple sites that I visit that just don't have certs,
so I can test.
Not banking sites or anything, just some sites.

Karl Dahlke

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Edbrowse-dev] subdomain match
  2014-09-13 15:18 [Edbrowse-dev] subdomain match Karl Dahlke
@ 2014-09-13 15:39 ` Chris Brannon
  0 siblings, 0 replies; 4+ messages in thread
From: Chris Brannon @ 2014-09-13 15:39 UTC (permalink / raw)
  To: Edbrowse-dev

Pushed.  Thanks for the code review.

-- Chris

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Edbrowse-dev] subdomain match
  2014-09-12 22:01 Karl Dahlke
@ 2014-09-13 13:42 ` Chris Brannon
  0 siblings, 0 replies; 4+ messages in thread
From: Chris Brannon @ 2014-09-13 13:42 UTC (permalink / raw)
  To: Edbrowse-dev

Karl Dahlke <eklhad@comcast.net> writes:

> If you proxy specifically on a domain does that include the subdomains?

It does.  So I'll fix my code!  Want me to resend to the list?

-- Chris

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Edbrowse-dev] subdomain match
@ 2014-09-12 22:01 Karl Dahlke
  2014-09-13 13:42 ` Chris Brannon
  0 siblings, 1 reply; 4+ messages in thread
From: Karl Dahlke @ 2014-09-12 22:01 UTC (permalink / raw)
  To: Edbrowse-dev

> My inclination is to be cautious and require an exact match.
> and I'm not sure why.

If we stay with that, but keep nojs spilling over into subdomains,
then we should carefully document the difference.
I personally think they should work the same way,
exact match or subdomains.
How does proxy work again, in .ebrc?
I don't remember.
If you proxy specifically on a domain does that include the subdomains?
Should this be consistent with the other two?
I would think so.

Karl Dahlke

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-09-13 15:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-13 15:18 [Edbrowse-dev] subdomain match Karl Dahlke
2014-09-13 15:39 ` Chris Brannon
  -- strict thread matches above, loose matches on Subject: below --
2014-09-12 22:01 Karl Dahlke
2014-09-13 13:42 ` Chris Brannon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).