Re: [Edbrowse-dev] compiling edbrowse with js24

[Chris Brannon <chris@the-brannons.com>]

Chuck Hallenbeck <chuckh@ftml.net> writes:

> Next question: If I modify the edbrowse makefile to add those flags, what
> happens to my modifications when the makefile iks updated?

Well, they get erased!
So don't modify the makefile.  I'd suggest a script like this one:

#!/bin/sh
# ebmake, build edbrowse
# Expects to be run from the root of the edbrowse tree,

LDFLAGS=-L/usr/local/lib make JS_CXXFLAGS=/usr/local/include/mozjs-24
# End of script.

This is sort of how we do things when packaging for distributions.
Typically, we don't write patches against the makefile, because they're
fragile.  It's better to set variables or flip configure switches.
Since edbrowse doesn't have a configure script, we end up setting
environment variables, or in the case of JS_CXXFLAGS, "make" variables.
Don't make the mistake of using JS_CXXFLAGS as an environment variable,
because make will override it.
Instead, it needs to be passed after the make command, so make will do
the substitution:
make JS_CXXFLAGS=whatever

-- Chris