From: Kevin Carhart <kevin@carhart.net>
To: edbrowse-dev@lists.the-brannons.com
Subject: [edbrowse-dev] resolveURL question (fwd)
Date: Mon, 1 Jul 2019 21:16:59 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1907012109020.21839@carhart.net> (raw)
I'm glad it was a one character change. I like the
way those parseURL arguments for the URL sections are done. I don't
think I have spent much time in url.c. It's nice that the phrasing of the
"resolve" debugPrints nailed down where the problem was. I thought at
first that it might be handleable by one of those Tidy Opt settings.
---------- Forwarded message ----------
Date: Mon, 01 Jul 2019 00:43:43 -0400
From: Karl Dahlke <eklhad@comcast.net>
To: edbrowse-dev@lists.the-brannons.com
Subject: [edbrowse-dev] resolveURL question
resolveURL seems like such a simple routine, but it has been a nightmare for about 15 years now.
That's why I have specific debug prints for it, at level 5, probably should be at level 4.
We need to see what it is doing and when it screwes up, like here.
The section you refer to is not relevant.
rel is the variable of the relative piece, and that code is for
rel = #foo
where I'm just changing the hash.
But here we have a new path, and the base has a hash, but the hash contains a slash, which I've never seen before.
parseURL handles it properly, so let's step through and see what goes wrong.
Line 885 is telling us where the problem is.
Fortunately the fix is literally a single character.
Karl Dahlke
reply other threads:[~2019-07-02 4:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1907012109020.21839@carhart.net \
--to=kevin@carhart.net \
--cc=edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).