Announcements and discussions for Gnus, the GNU Emacs Usenet newsreader
 help / color / mirror / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: info-gnus-english@gnu.org
Subject: Re: Update topic unread counts on group exit?
Date: Wed, 04 May 2022 18:00:18 -0700	[thread overview]
Message-ID: <874k24pzdp.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87bkwdj7lw.fsf@tullinup.koldfront.dk>

Adam Sjøgren <asjo@koldfront.dk> writes:

> Eric writes:
>
>> I'll remove the checks now.
>
> The line the error is triggered in is:
>
>     (defun gnus-topic-update-topic-line (topic-name &optional reads)
>       (let* ((top (gnus-topic-find-topology topic-name))
>              (type (cadr top))
>              (children (cddr top))
>              (entries (gnus-topic-find-groups
>                        (car type) (car gnus-group-list-mode)
>                        (cdr gnus-group-list-mode)))
>              (all-groups (gnus-topic-find-groups
>                        (car type) (car gnus-group-list-mode)
>                        (cdr gnus-group-list-mode) t))         <------ HERE
>              (parent (gnus-topic-parent-topic topic-name))
>
> gnus-topic-find-groups: Wrong type argument: number-or-marker-p, t
>
> gnus-group-list-mode is (5) here, so the cdr is nil, and
> gnus-topic-find-groups doesn't like that, apparently. I didn't have time
> to step through that to pinpoint it further.

Looks like Dick Chiang has already opened a bug report containing the
fix, so expect this to work Real Soon Now.



  reply	other threads:[~2022-05-05  1:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04 17:35 Adam Sjøgren
2022-05-04 17:58 ` Eric Abrahamsen
2022-05-04 18:17   ` Adam Sjøgren
2022-05-04 18:23     ` Adam Sjøgren
2022-05-04 19:51       ` Eric Abrahamsen
2022-05-04 21:16         ` Adam Sjøgren
2022-05-04 21:44         ` Adam Sjøgren
2022-05-05  1:00           ` Eric Abrahamsen [this message]
2022-05-05  4:36             ` Adam Sjøgren
2022-05-04 18:32     ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k24pzdp.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=info-gnus-english@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).