From: "N. Jackson" <nljlistbox2@gmail.com>
To: info-gnus-english@gnu.org
Subject: Typo in doc string of `gnus-dependencies-add-header'?
Date: Sun, 22 Jul 2018 09:37:36 -0400 [thread overview]
Message-ID: <87a7qjv1b3.fsf@moondust.localdomain> (raw)
In Gnus v5.13 in GNU Emacs 27.0.50
Repository revision: f3f67cf0b9a6388d423e048a7aafad2eb531b5a5
While poking around [1] in the code, I stumbled across something in
`gnus-dependencies-add-header' that confused me. If I understand
correctly, there is typo in the doc string.
The paragraph in question says:
If `gnus-summary-ignore-duplicates' is nil then duplicate
^^^^^^
Message-IDs will not be entered in the DEPENDENCIES table.
Otherwise duplicate Message-IDs will be renamed to a unique
Message-ID before being entered.
but it seems to me that this should begin:
If `gnus-summary-ignore-duplicates' is not nil ...
.
The relevant code seems to be in the `cond' in
`gnus-dependencies-add-header' at Line 4323 of gnus-sum.el:
(cond
...
;; Renames the existing `header' to a unique Message-ID.
((not gnus-summary-ignore-duplicates)
;; An article with this Message-ID has already been seen.
;; We rename the Message-ID.
(set (setq id-dep (intern (setq id (nnmail-message-id)) dependencies))
(list header))
(mail-header-set-id header id))
...
)
Am I right that the doc string is wrong, or am I missing something?
(I could easily be missing something: trying to read Lisp makes my
head hurt! (The world would be so much kinder on my noggin if
everything were written in C.))
Thanks.
N.
[1] I'm trying to get a better understanding of Bug#28477
(https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28477) where Gnus
occasionally gets the order wrong when displaying threads (and
will show message A as reply to message B when in fact message B
was the later message and responds to message A).
next reply other threads:[~2018-07-22 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-22 13:37 N. Jackson [this message]
2018-07-22 17:00 ` Eric Abrahamsen
2018-07-22 19:24 ` N. Jackson
2018-07-22 20:17 ` Eric Abrahamsen
2018-07-24 17:56 ` N. Jackson
2018-07-24 20:14 ` Eric Abrahamsen
2018-07-26 0:37 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7qjv1b3.fsf@moondust.localdomain \
--to=nljlistbox2@gmail.com \
--cc=info-gnus-english@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).