Re: Scope of headers in posting styles

Re: Scope of headers in posting styles

[Svend Tollak Munkejord]

On 2004-09-23, Reiner Steib <4.uce.03.r.s@nurfuerspam.de> wrote:

> On Thu, Sep 23 2004, Svend Tollak Munkejord wrote:
>
>> 	((header "From" ".*\\.mydomain\\>")
>> 	 (eval (setq tc-make-attribution 'my-simple-attribution))
> [...]
>> It comes into action when I reply to messages coming from
>> mydomain. However, it is *also* turned on when I reply to messages
>> containing ugly Outlook citation blocks:
> [...]
>> From: "Svend Tollak Munkejord" <svend@mydomain>
> [...]
>> Is this a bug? Shouldn't Gnus limit itself to consider the real
>> message headers? Or do I have to tell it to do so, somehow?
>
> I cannot reproduce this.  

Thanks for your prompt response.

> When I add your example to my `gnus-posting-styles', replying to
> your message isn't triggered (tc-make-attribution is void).

I use trivial-cite, but the problem isn't related to
trivial-cite. Sorry for that. Let me give a simpler example that shows
the same problem.

	((header "From" ".*\\.mydomain\\>")
         (signature "Gobbledeegook"))

Now Gnus inserts the Gobbledeegook signature when I reply to a message
containing the ugly Outlook citation block, even if the real From
header does not contain "mydomain" in any way.

-- 
Svend Tollak Munkejord 

Re: Scope of headers in posting styles

[Reiner Steib]

On Thu, Sep 23 2004, Svend Tollak Munkejord wrote:

> On 2004-09-23, Reiner Steib <4.uce.03.r.s@nurfuerspam.de> wrote:
[...]
>> When I add your example to my `gnus-posting-styles', replying to
>> your message isn't triggered (tc-make-attribution is void).
>
> I use trivial-cite, but the problem isn't related to
> trivial-cite. 

Yes, I know.  But replying to your first message (with the Outlook
quote) should trigger the eval/setq statement, but it doesn't.

Ah, the reason is, that "<svend@mydomain>" doesn't match
".*\\.mydomain\\>" (note the dot).  Now I could reproduce it.

Could you test the following patch?

--8<---------------cut here---------------start------------->8---
--- gnus-msg.el	22 Sep 2004 04:40:39 -0000	7.21
+++ gnus-msg.el	23 Sep 2004 11:39:05 -0000
@@ -1827,9 +1827,11 @@
 		  ;; New format of header match.
 		  (and (gnus-buffer-live-p gnus-article-copy)
 		       (with-current-buffer gnus-article-copy
-			 (let ((header (message-fetch-field (nth 1 match))))
-			   (and header
-				(string-match (nth 2 match) header))))))
+			 (save-restriction
+			   (nnheader-narrow-to-headers)
+			   (let ((header (message-fetch-field (nth 1 match))))
+			     (and header
+				  (string-match (nth 2 match) header)))))))
 		 (t
 		  ;; This is a form to be evaled.
 		  (eval match)))))
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.