Logic error in mandoc.c time2a()

Logic error in mandoc.c time2a()

[Ulrich Spörlein]

Hi,

now that the clang/llvm folks unbroke their static analysis tool again,
I had another run on the mdocml sources. Only one bug stood out
(disregard the 'Dead store' class).

See https://www.spoerlein.net/scan-build/mdocml/2011-03-11-1/

In time2a(), 'buf' is a stack-local buffer and its address will be
returned. Oops. Either make it global, static, use malloc/free, or have
the caller provide the buffer, not sure which solution you guys would
prefer.

Uli
--
 To unsubscribe send an email to discuss+unsubscribe@mdocml.bsd.lv

Re: Logic error in mandoc.c time2a()

[Ingo Schwarze]

Hi Ulrich,

Ulrich Spoerlein wrote on Fri, Mar 11, 2011 at 09:42:04PM +0100:

> now that the clang/llvm folks unbroke their static analysis tool again,
> I had another run on the mdocml sources. Only one bug stood out
> (disregard the 'Dead store' class).
> 
> See https://www.spoerlein.net/scan-build/mdocml/2011-03-11-1/
> 
> In time2a(), 'buf' is a stack-local buffer and its address will be
> returned. Oops.

Oops indeed, i guess i'm programming too much in Perl lately,
forming bad habits like returning references to local storage.

> Either make it global, static, use malloc/free,

malloc is the way to go here; time2a ist static and called
from one place only, and the return value is strdup'ed right
away, so we can as well malloc it in the first place.
I need to cook a diff...

> or have the caller provide the buffer, not sure which solution you guys
> would prefer.

Thanks,
  Ingo
--
 To unsubscribe send an email to discuss+unsubscribe@mdocml.bsd.lv