From: schwarze@mandoc.bsd.lv
To: source@mandoc.bsd.lv
Subject: cvsweb: two more instances of missing HTML quoting; candidates found
Date: Wed, 6 Nov 2019 12:11:30 -0500 (EST) [thread overview]
Message-ID: <8d075fa55a992b6c@mandoc.bsd.lv> (raw)
Log Message:
-----------
two more instances of missing HTML quoting;
candidates found when i quickly scanned the code;
afresh1@ confirmed these two are potentially problematic
Tags:
----
FreeBSD-cvsweb-2_0-branch
Modified Files:
--------------
cvsweb:
cvsweb.cgi
Revision Data
-------------
Index: cvsweb.cgi
===================================================================
RCS file: /home/cvs/mandoc/cvsweb/cvsweb.cgi,v
retrieving revision 3.119.2.16
retrieving revision 3.119.2.17
diff -Lcvsweb.cgi -Lcvsweb.cgi -u -p -r3.119.2.16 -r3.119.2.17
--- cvsweb.cgi
+++ cvsweb.cgi
@@ -2889,7 +2889,7 @@ sub doLog($) {
print " selected"
if (defined($input{"only_with_tag"})
&& $input{"only_with_tag"} eq $_);
- print ">${_}</option>\n";
+ printf ">%s</option>\n", htmlquote($_);
}
print "</select></td>\n<td></td>\n</tr>\n";
}
@@ -3286,7 +3286,8 @@ sub chooseCVSRoot() {
if (2 <= @CVSROOT) {
my ($k);
foreach $k (keys %input) {
- print "<input type=\"hidden\" name=\"$k\" value=\"$input{$k}\">\n"
+ printf '<input type="hidden" name="%s" value="%s">' .
+ "\n", htmlquote($k), htmlquote($input{$k})
if ($input{$k}) && ($k ne "cvsroot");
}
--
To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv
reply other threads:[~2019-11-06 17:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d075fa55a992b6c@mandoc.bsd.lv \
--to=schwarze@mandoc.bsd.lv \
--cc=source@mandoc.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).