* cvsweb: two more instances of missing HTML quoting; candidates found
@ 2019-11-06 17:11 schwarze
0 siblings, 0 replies; only message in thread
From: schwarze @ 2019-11-06 17:11 UTC (permalink / raw)
To: source
Log Message:
-----------
two more instances of missing HTML quoting;
candidates found when i quickly scanned the code;
afresh1@ confirmed these two are potentially problematic
Tags:
----
FreeBSD-cvsweb-2_0-branch
Modified Files:
--------------
cvsweb:
cvsweb.cgi
Revision Data
-------------
Index: cvsweb.cgi
===================================================================
RCS file: /home/cvs/mandoc/cvsweb/cvsweb.cgi,v
retrieving revision 3.119.2.16
retrieving revision 3.119.2.17
diff -Lcvsweb.cgi -Lcvsweb.cgi -u -p -r3.119.2.16 -r3.119.2.17
--- cvsweb.cgi
+++ cvsweb.cgi
@@ -2889,7 +2889,7 @@ sub doLog($) {
print " selected"
if (defined($input{"only_with_tag"})
&& $input{"only_with_tag"} eq $_);
- print ">${_}</option>\n";
+ printf ">%s</option>\n", htmlquote($_);
}
print "</select></td>\n<td></td>\n</tr>\n";
}
@@ -3286,7 +3286,8 @@ sub chooseCVSRoot() {
if (2 <= @CVSROOT) {
my ($k);
foreach $k (keys %input) {
- print "<input type=\"hidden\" name=\"$k\" value=\"$input{$k}\">\n"
+ printf '<input type="hidden" name="%s" value="%s">' .
+ "\n", htmlquote($k), htmlquote($input{$k})
if ($input{$k}) && ($k ne "cvsroot");
}
--
To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-11-06 17:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 17:11 cvsweb: two more instances of missing HTML quoting; candidates found schwarze
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).