mandoc: Avoid a read access one byte beyond the end of an allocated

mandoc: Avoid a read access one byte beyond the end of an allocated

[schwarze]

Log Message:
-----------
Avoid a read access one byte beyond the end of an allocated string
which occurred in situations like ".Fl a Cm --"; found by 
Leah Neukirchen <leah at vuxu dot org> with valgrind on Void Linux.

Modified Files:
--------------
    mandoc:
        mdoc_validate.c
        NEWS

Revision Data
-------------
Index: mdoc_validate.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/mdoc_validate.c,v
retrieving revision 1.358
retrieving revision 1.359
diff -Lmdoc_validate.c -Lmdoc_validate.c -u -p -r1.358 -r1.359
--- mdoc_validate.c
+++ mdoc_validate.c
@@ -440,7 +440,7 @@ check_text_em(struct roff_man *mdoc, int
 		     np->string != '\0' &&
 		     isalpha((unsigned char)np->string[
 		       strlen(np->string) - 1])) ||
-		    (cp[2] != '\0' ?
+		    (cp[1] != '\0' && cp[2] != '\0' ?
 		     isalpha((unsigned char)cp[2]) :
 		     nn != NULL &&
 		     nn->type == ROFFT_TEXT &&
Index: NEWS
===================================================================
RCS file: /home/cvs/mandoc/mandoc/NEWS,v
retrieving revision 1.29
retrieving revision 1.30
diff -LNEWS -LNEWS -u -p -r1.29 -r1.30
--- NEWS
+++ NEWS
@@ -59,8 +59,8 @@ Changes in version 1.14.4, released on A
    on diagnostic messages and on the documentation.
  * Thomas Klausner (NetBSD) for suggesting two new style messages,
    one new feature, and for two bug reports.
- * Leah Neukirchen (Void Linux) for suggesting a new style message
-   and for two bug reports.
+ * Leah Neukirchen (Void Linux) for suggesting a new style message,
+   four bug reports, and release testing.
  * Anthony Bentley (OpenBSD) for reporting multiple bugs and missing
    features.
  * Paul Irofti (OpenBSD) and Nate Bargmann for suggesting new features.
--
 To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv