mandoc: Fix an off-by-one string read access that could happen if an

mandoc: Fix an off-by-one string read access that could happen if an

[schwarze]

Log Message:
-----------
Fix an off-by-one string read access that could happen if an empty
string argument preceded a string argument beginning with "--".
Found by Leah Neukirchen <leah at vuxu dot org> with -Wpointer-compare.

Modified Files:
--------------
    mandoc:
        mdoc_validate.c

Revision Data
-------------
Index: mdoc_validate.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/mdoc_validate.c,v
retrieving revision 1.359
retrieving revision 1.360
diff -Lmdoc_validate.c -Lmdoc_validate.c -u -p -r1.359 -r1.360
--- mdoc_validate.c
+++ mdoc_validate.c
@@ -437,14 +437,13 @@ check_text_em(struct roff_man *mdoc, int
 		     isalpha((unsigned char)cp[-3]) :
 		     np != NULL &&
 		     np->type == ROFFT_TEXT &&
-		     np->string != '\0' &&
+		     *np->string != '\0' &&
 		     isalpha((unsigned char)np->string[
 		       strlen(np->string) - 1])) ||
 		    (cp[1] != '\0' && cp[2] != '\0' ?
 		     isalpha((unsigned char)cp[2]) :
 		     nn != NULL &&
 		     nn->type == ROFFT_TEXT &&
-		     nn->string != '\0' &&
 		     isalpha((unsigned char)*nn->string))) {
 			mandoc_msg(MANDOCERR_DASHDASH, mdoc->parse,
 			    ln, pos + (int)(cp - p) - 1, NULL);
--
 To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv