From: schwarze@mandoc.bsd.lv
To: source@mandoc.bsd.lv
Subject: cvsweb: For more than 15 years, running cvsweb.cgi hasn't been tested
Date: Thu, 21 Mar 2019 11:40:58 -0500 (EST) [thread overview]
Message-ID: <e3fc8403dbf7f8c3@fantadrom.bsd.lv> (raw)
Log Message:
-----------
For more than 15 years, running cvsweb.cgi hasn't been tested
with Perl taint checks, and the following commit message from
patch-cvsweb_cgi rev. 1.11 from the OpenBSD port indicates that
there were already issues with Perl 5.8.
Very likely, things only got worse during all those years.
While re-auditing the whole program for taint safety would certainly
make sense, i'm not going to do that for the legacy 2.0 codebase.
So simply disable taint checks on this branch. Hopefully, in the
not too distant future, we can get the 4.x trunk into shape, audit
*that*, and then get server admins to upgrade to 4.x.
Relevant part of the original commit message:
date: 2003/08/16 23:18:41; author: naddy;
* upstreamer maintainer suggests that we run without taint checks on perl 5.8
* [...]
Tags:
----
FreeBSD-cvsweb-2_0-branch
Modified Files:
--------------
cvsweb:
cvsweb.cgi
Revision Data
-------------
Index: cvsweb.cgi
===================================================================
RCS file: /home/cvs/mandoc/cvsweb/cvsweb.cgi,v
retrieving revision 3.119.2.12
retrieving revision 3.119.2.13
diff -Lcvsweb.cgi -Lcvsweb.cgi -u -p -r3.119.2.12 -r3.119.2.13
--- cvsweb.cgi
+++ cvsweb.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -wT
+#!/usr/bin/perl -w
#
# cvsweb - a CGI interface to CVS trees.
#
--
To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv
reply other threads:[~2019-03-21 16:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3fc8403dbf7f8c3@fantadrom.bsd.lv \
--to=schwarze@mandoc.bsd.lv \
--cc=source@mandoc.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).