source@mandoc.bsd.lv
 help / color / mirror / Atom feed
* cvsweb: For more than 15 years, running cvsweb.cgi hasn't been tested
@ 2019-03-21 16:40 schwarze
  0 siblings, 0 replies; only message in thread
From: schwarze @ 2019-03-21 16:40 UTC (permalink / raw)
  To: source

Log Message:
-----------
For more than 15 years, running cvsweb.cgi hasn't been tested
with Perl taint checks, and the following commit message from
patch-cvsweb_cgi rev. 1.11 from the OpenBSD port indicates that
there were already issues with Perl 5.8.
Very likely, things only got worse during all those years.

While re-auditing the whole program for taint safety would certainly
make sense, i'm not going to do that for the legacy 2.0 codebase.
So simply disable taint checks on this branch.  Hopefully, in the
not too distant future, we can get the 4.x trunk into shape, audit
*that*, and then get server admins to upgrade to 4.x.

Relevant part of the original commit message:
date: 2003/08/16 23:18:41;  author: naddy;
* upstreamer maintainer suggests that we run without taint checks on perl 5.8
* [...]

Tags:
----
FreeBSD-cvsweb-2_0-branch

Modified Files:
--------------
    cvsweb:
        cvsweb.cgi

Revision Data
-------------
Index: cvsweb.cgi
===================================================================
RCS file: /home/cvs/mandoc/cvsweb/cvsweb.cgi,v
retrieving revision 3.119.2.12
retrieving revision 3.119.2.13
diff -Lcvsweb.cgi -Lcvsweb.cgi -u -p -r3.119.2.12 -r3.119.2.13
--- cvsweb.cgi
+++ cvsweb.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -wT
+#!/usr/bin/perl -w
 #
 # cvsweb - a CGI interface to CVS trees.
 #
--
 To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-03-21 16:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 16:40 cvsweb: For more than 15 years, running cvsweb.cgi hasn't been tested schwarze

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).