From: "Ulrich Spörlein" <uqs@spoerlein.net>
To: tech@mdocml.bsd.lv
Subject: Re: Reducing uname footer string on FreeBSD
Date: Mon, 14 Jun 2010 19:36:23 +0200 [thread overview]
Message-ID: <20100614173623.GF3632@acme.spoerlein.net> (raw)
In-Reply-To: <4C153267.5080904@bsd.lv>
On Sun, 13.06.2010 at 21:32:55 +0200, Kristaps Džonsons wrote:
> >> The attached patch clamps the string after the dash, iff uname reports
> >> we are running on FreeBSD. I don't think such special casing should be
> >> applied in the general source tree, but wanted to put it up for
> >> discussion anyway.
> >
> > Actually, i wouldn't even object to this particular patch going in
> > in case that's easier for you. After all,
> >
> > - post_os() is typically called once per input file;
> > - this is the central place where OS names are handled,
> > so having differences here is not that surprising;
> > - your patch is not expensive: linear in the length
> > of the string "FreeBSD" on FreeBSD, one return-at-once
> > function call everywhere else.
> >
> > So, even if all the four major free BSD implementations would
> > need something like this in post_os(), it would still seem
> > reasonable to me.
>
> Ulrich and Ingo, I have no objection to this being merged so long as you
> (Ulrich) can guarantee that this behaviour is general, i.e., that this
> will not cause badness in any sort of FreeBSD configuration.
I cannot think of any badness that this could trigger. groff(1) on
FreeBSD has been doing this for a very long time.
I will double check and commit if everything checks out.
Uli
--
To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv
next prev parent reply other threads:[~2010-06-14 17:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 16:34 Ulrich Spörlein
2010-06-12 17:18 ` Ingo Schwarze
2010-06-13 19:32 ` Kristaps Dzonsons
2010-06-14 17:36 ` Ulrich Spörlein [this message]
2010-06-13 21:13 ` Joerg Sonnenberger
2010-06-14 17:32 ` Ulrich Spörlein
2010-06-14 19:34 ` Joerg Sonnenberger
2010-06-14 20:22 ` Ulrich Spörlein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614173623.GF3632@acme.spoerlein.net \
--to=uqs@spoerlein.net \
--cc=tech@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).