Re: Reducing uname footer string on FreeBSD

["Ulrich Spörlein" <uqs@spoerlein.net>]

On Sun, 13.06.2010 at 21:32:55 +0200, Kristaps Džonsons wrote:
> >> The attached patch clamps the string after the dash, iff uname reports
> >> we are running on FreeBSD. I don't think such special casing should be
> >> applied in the general source tree, but wanted to put it up for
> >> discussion anyway.
> > 
> > Actually, i wouldn't even object to this particular patch going in
> > in case that's easier for you.  After all,
> > 
> >  - post_os() is typically called once per input file;
> >  - this is the central place where OS names are handled,
> >    so having differences here is not that surprising;
> >  - your patch is not expensive:  linear in the length
> >    of the string "FreeBSD" on FreeBSD, one return-at-once
> >    function call everywhere else.
> > 
> > So, even if all the four major free BSD implementations would
> > need something like this in post_os(), it would still seem
> > reasonable to me.
> 
> Ulrich and Ingo, I have no objection to this being merged so long as you 
> (Ulrich) can guarantee that this behaviour is general, i.e., that this 
> will not cause badness in any sort of FreeBSD configuration.

I cannot think of any badness that this could trigger. groff(1) on
FreeBSD has been doing this for a very long time.

I will double check and commit if everything checks out.

Uli
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv