Re: tweak message "scope open on exit"

[Ingo Schwarze <schwarze@usta.de>]

Hi Kristaps,

Kristaps Dzonsons wrote on Sun, Sep 26, 2010 at 11:13:05AM +0200:
> Ingo Schwarze wrote:

>> in mdoc(7), if an explicit scope is still open at the end of an input
>> file, that's FATAL.  I really don't see why, it's trivial to just
>> close out the block and proceed to rendering the file.
>>
>> On the other hand, in man(7), if an explicit scope is still open at
>> the end of an input file, that's merely a WARNING.  I regard that
>> as dangerous, because an unclosed block probably means that either:
[...]
>>
>> As i see it, that's a typical case of a non-fatal ERROR:
>> We can render, but probably infomation is missing or the
>> structure is seriously mangled.
>>
>> Besides, why not use the same error type for mdoc(7) and man(7)?
>>
>> And finally, since we do know that the error is non-fatal,
>> there is no need to check the return value of the msg function.

> Ingo, this looks good.  At first I dithered for a while about
> returning 0 to mdoc_endparse(), but because the error is non-fatal,
> your reasoning is sound and I agree.

Right, that is the good news about mdoc_nmsg() and friends,
basically about all messaging functions based on main.c, function
mmsg():  These functions now cannot fail any more, and we know
the return value beforehand, so in the long run, we can drop
all the return value tests and finally make mmsg() void.
That will shorten much of the code and make it easier on the eye.

I don't see the pressing need for big churn right now and rather
plan to simplify what needs to be touched anyway, as we go.

> Can you fix up the WARNING->ERROR logic in libman, too?

I don't think anything more needs to be done, in particular
i can't think of anything to change in man*.c.
As far as i understand, just moving the entry in the lists
in mandoc.h and main.c does the trick for man.

Or am i missing anything?

Yours,
  Ingo
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv