From: Kristaps Dzonsons <kristaps@bsd.lv>
To: tech@mdocml.bsd.lv
Subject: Re: tweak message "scope open on exit"
Date: Sun, 26 Sep 2010 11:13:05 +0200 [thread overview]
Message-ID: <4C9F0EA1.3080302@bsd.lv> (raw)
In-Reply-To: <20100923225445.GG11894@iris.usta.de>
> in mdoc(7), if an explicit scope is still open at the end of an input
> file, that's FATAL. I really don't see why, it's trivial to just
> close out the block and proceed to rendering the file.
>
> On the other hand, in man(7), if an explicit scope is still open at
> the end of an input file, that's merely a WARNING. I regard that
> as dangerous, because an unclosed block probably means that either:
>
> - some input text is missing, resulting in incomplete output
> - or closure of a block is missing, probably resulting in
> garbled document structure from that point onwards.
>
> As i see it, that's a typical case of a non-fatal ERROR:
> We can render, but probably infomation is missing or the
> structure is seriously mangled.
>
> Besides, why not use the same error type for mdoc(7) and man(7)?
>
> And finally, since we do know that the error is non-fatal,
> there is no need to check the return value of the msg function.
Ingo, this looks good. At first I dithered for a while about returning
0 to mdoc_endparse(), but because the error is non-fatal, your reasoning
is sound and I agree.
Can you fix up the WARNING->ERROR logic in libman, too?
Thanks,
Kristaps
--
To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv
next prev parent reply other threads:[~2010-09-26 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 22:54 Ingo Schwarze
2010-09-26 9:13 ` Kristaps Dzonsons [this message]
2010-09-26 13:14 ` Ingo Schwarze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9F0EA1.3080302@bsd.lv \
--to=kristaps@bsd.lv \
--cc=tech@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).