From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: tech@mdocml.bsd.lv
Subject: Re: implement .so
Date: Tue, 26 Oct 2010 20:12:52 +0200 [thread overview]
Message-ID: <20101026181252.GA4964@britannica.bec.de> (raw)
In-Reply-To: <20101026175913.GF27536@iris.usta.de>
On Tue, Oct 26, 2010 at 07:59:13PM +0200, Ingo Schwarze wrote:
> So, here is a simplified patch (less than 50 new lines of code,
> all very simple) relying on the current working directory.
I would like to a see a warning for -T lint, but I am not sure how that
could be implemented easily.
> +roff_so(ROFF_ARGS)
> +{
> + char *name;
> +
> + name = *bufp + pos;
> + if ('/' == *name || strstr(name, "../") || strstr(name, "/..")) {
> + (*r->msg)(MANDOCERR_SOPATH, r->data, ln, pos, NULL);
> + return(ROFF_ERR);
> + }
Not sure I like the double use of strstr. What about searching for the
rare ".." first?
Joerg
--
To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv
next prev parent reply other threads:[~2010-10-26 18:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 16:40 Ingo Schwarze
2010-10-24 16:49 ` Joerg Sonnenberger
2010-10-24 17:29 ` Ingo Schwarze
2010-10-24 17:38 ` Joerg Sonnenberger
2010-10-24 18:00 ` Ingo Schwarze
2010-10-24 18:15 ` Joerg Sonnenberger
2010-10-24 18:17 ` Joerg Sonnenberger
2010-10-24 19:41 ` Ingo Schwarze
2010-10-24 19:51 ` Joerg Sonnenberger
2010-10-25 21:55 ` Ingo Schwarze
2010-10-25 22:10 ` Joerg Sonnenberger
2010-10-26 17:59 ` Ingo Schwarze
2010-10-26 18:12 ` Joerg Sonnenberger [this message]
2010-10-26 21:48 ` Ingo Schwarze
2010-10-26 21:56 ` Joerg Sonnenberger
2010-10-26 23:10 ` Ingo Schwarze
2010-10-26 23:30 ` Joerg Sonnenberger
2010-10-26 23:41 ` Ingo Schwarze
2010-10-27 9:34 ` Kristaps Dzonsons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026181252.GA4964@britannica.bec.de \
--to=joerg@britannica.bec.de \
--cc=tech@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).