Re: implement .so

[Ingo Schwarze <schwarze@usta.de>]

Hi Joerg,

Thanks for your quick feedback!

Joerg Sonnenberger wrote on Tue, Oct 26, 2010 at 08:12:52PM +0200:

> I would like to a see a warning for -T lint, but I am not sure how that
> could be implemented easily.

I think i know how to put that in, it doesn't seem like any kind of
a problem.  But i'd rather do that after committing the ERROR cleanup
i posted recently, or it will conflict badly.

> On Tue, Oct 26, 2010 at 07:59:13PM +0200, Ingo Schwarze wrote:

>> +roff_so(ROFF_ARGS)
>> +{
>> +	char *name;
>> +
>> +	name = *bufp + pos;
>> +	if ('/' == *name || strstr(name, "../") || strstr(name, "/..")) {
>> +		(*r->msg)(MANDOCERR_SOPATH, r->data, ln, pos, NULL);
>> +		return(ROFF_ERR);
>> +	}

> Not sure I like the double use of strstr.
> What about searching for the rare ".." first?

Admittedly, that would allow to reduce the algorithm order
from O(2N) to O(N), where N is the length of the name of the
included file, so not exactly a large number.

Given that you almost never have more than one .so per file,
i consider readability of the code more important here than
economizing typically about 20 character comparisons.

So, i think i will put in the pdesc refactoring, then .so,
then the ERROR cleanup, then add a warning message.

OK?

Yours,
  Ingo
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv