tech@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: Ingo Schwarze <schwarze@usta.de>
To: tech@mdocml.bsd.lv
Subject: Re: mdocml: Bail out explicitly on invalid .Rs content like: .Rs plain text
Date: Sun, 20 Nov 2011 13:37:20 +0100	[thread overview]
Message-ID: <20111120123720.GC31954@iris.usta.de> (raw)
In-Reply-To: <20111120042741.GF16040@britannica.bec.de>

Hi Joerg,

Joerg Sonnenberger wrote on Sun, Nov 20, 2011 at 05:27:41AM +0100:
> On Sat, Nov 19, 2011 at 02:32:20PM +0100, Ingo Schwarze wrote:

>> i could confirm both the problem and the fix, and i don't see any
>> regressions, so i have merged this to OpenBSD and improved the
>> comment a bit.

> There is one aspect to consider. We drop
> .Rs
> plain text
> .Re
> silently now, when groff renders it.

Sure, i have a test case for that in my private collection of
failing test cases.  If anybody considers it of sufficient
importance, feel free to add it to TODO.  Typically, i add
stuff to TODO when i see a case in practice where it matters,
and i haven't yet seen one involving plain text in .Rs.

ischwarze@isnote $ cd /usr/src/regress/usr.bin/mandoc/TODO/                    
ischwarze@isnote $ find . -name '*.in' | wc -l              
      98

For the time being, your patch prevents a crash, which is already
a real improvement.

Yours,
  Ingo
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

      reply	other threads:[~2011-11-20 12:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201111181458.pAIEwOCM016755@krisdoz.my.domain>
2011-11-19 13:32 ` Ingo Schwarze
2011-11-20  4:27   ` Joerg Sonnenberger
2011-11-20 12:37     ` Ingo Schwarze [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111120123720.GC31954@iris.usta.de \
    --to=schwarze@usta.de \
    --cc=tech@mdocml.bsd.lv \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).