From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: tech@mdocml.bsd.lv
Subject: Re: mdocml: Convert an assert into an explicit check.
Date: Sat, 3 Dec 2011 23:47:55 +0100 [thread overview]
Message-ID: <20111203224755.GC3697@britannica.bec.de> (raw)
In-Reply-To: <20111203214157.GH17667@iris.usta.de>
On Sat, Dec 03, 2011 at 10:41:57PM +0100, Ingo Schwarze wrote:
> That function just works fine even when the syntax tree is completely
> empty, only containing the ROOT node. It is important to *NOT*
> return early, but to continue through the whole function and execute
> the man_valid_post(m) near the end - otherwise, you will end up
> with NULL pointers in the meta structure and provoke the crashes
> you observed.
In that case at least assert that m->title etc are not NULL.
Joerg
--
To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv
next prev parent reply other threads:[~2011-12-03 22:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201111181639.pAIGd8Y3022061@krisdoz.my.domain>
2011-11-19 14:19 ` Ingo Schwarze
2011-11-20 4:25 ` Joerg Sonnenberger
2011-11-20 4:26 ` Joerg Sonnenberger
2011-11-20 12:27 ` Ingo Schwarze
2011-11-20 19:17 ` Joerg Sonnenberger
2011-12-03 21:41 ` Ingo Schwarze
2011-12-03 22:47 ` Joerg Sonnenberger [this message]
2011-12-03 23:50 ` Ingo Schwarze
2011-12-04 0:15 ` Joerg Sonnenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111203224755.GC3697@britannica.bec.de \
--to=joerg@britannica.bec.de \
--cc=tech@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).