Re: mdocml: Convert an assert into an explicit check.

[Ingo Schwarze <schwarze@usta.de>]

Hi Joerg,

Joerg Sonnenberger wrote on Sun, Nov 20, 2011 at 05:26:44AM +0100:
> On Sun, Nov 20, 2011 at 05:25:12AM +0100, Joerg Sonnenberger wrote:
>> On Sat, Nov 19, 2011 at 03:19:07PM +0100, Ingo Schwarze wrote:
>>> joerg@mdocml.bsd.lv wrote on Fri, Nov 18, 2011 at 11:39:08AM -0500:

>>>> Log Message:
>>>> -----------
>>>> Convert an assert into an explicit check. man_unscope can be triggered
>>>> on unknown macros.
>>>> 
>>>> Modified Files:
>>>> --------------
>>>>     mdocml:
>>>>         man_macro.c

>>> Sorry, so far i failed to reproduce the problem.
>>> Can you provide an example?

>> .ab help2man is required to generate this page
>> 
>> was the case that originally triggered this.

> I think this also triggers the other case with missing default settings
> in man_term.c later.

Oh, now i see.
It's not mandoc(1) that is crashing on that one, but groff(1);
the .ab request means "abort".
Sure, .ab is ignored by mandoc, but when you run a unit test
with both groff and mandoc on a file containing .ab, the test
fails because groff fails.
Obviously, you have mistaken that for a mandoc failure.

So please back out both bogus patches, unless you can demonstrate
that there is a problem with mandoc.
The following two test files both work for me with mandoc
and both abort with groff.
Commenting out any number of .TH arguments, or the whole .TH line,
doesn't reveal any problems either.

Yours,
  Ingo


ischwarze@isnote $ cat badbefore.in     
.ab help2man is required to generate this page
.TH TH-BADBEFORE 1 "November 19, 2011"
.SH NAME
TH-badbefore \- unknown macro before .TH
.SH DESCRIPTION
Some text.
ischwarze@isnote $ cat badafter.in                                             
.TH TH-BADAFTER 1 "November 19, 2011"
.ab help2man is required to generate this page
.SH NAME
TH-badafter \- unknown macro after .TH
.SH DESCRIPTION
Some text.
ischwarze@isnote $ mandoc badbefore.in > /dev/null && echo ok                  
ok
ischwarze@isnote $ mandoc badafter.in > /dev/null && echo ok  
ok
ischwarze@isnote $ /usr/local/bin/nroff -mandoc -Tascii -c badbefore.in        
help2man is required to generate this page
ischwarze@isnote $ /usr/local/bin/nroff -mandoc -Tascii -c badafter.in  
TH-BADAFTER(1)                                                  TH-BADAFTER(1)
help2man is required to generate this page
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv