help / color / mirror / Atom feed
From: Ingo Schwarze <>
To: Joerg Sonnenberger <>
Subject: Re: mdocml: Convert an assert into an explicit check.
Date: Sun, 20 Nov 2011 13:27:10 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Joerg,

Joerg Sonnenberger wrote on Sun, Nov 20, 2011 at 05:26:44AM +0100:
> On Sun, Nov 20, 2011 at 05:25:12AM +0100, Joerg Sonnenberger wrote:
>> On Sat, Nov 19, 2011 at 03:19:07PM +0100, Ingo Schwarze wrote:
>>> wrote on Fri, Nov 18, 2011 at 11:39:08AM -0500:

>>>> Log Message:
>>>> -----------
>>>> Convert an assert into an explicit check. man_unscope can be triggered
>>>> on unknown macros.
>>>> Modified Files:
>>>> --------------
>>>>     mdocml:
>>>>         man_macro.c

>>> Sorry, so far i failed to reproduce the problem.
>>> Can you provide an example?

>> .ab help2man is required to generate this page
>> was the case that originally triggered this.

> I think this also triggers the other case with missing default settings
> in man_term.c later.

Oh, now i see.
It's not mandoc(1) that is crashing on that one, but groff(1);
the .ab request means "abort".
Sure, .ab is ignored by mandoc, but when you run a unit test
with both groff and mandoc on a file containing .ab, the test
fails because groff fails.
Obviously, you have mistaken that for a mandoc failure.

So please back out both bogus patches, unless you can demonstrate
that there is a problem with mandoc.
The following two test files both work for me with mandoc
and both abort with groff.
Commenting out any number of .TH arguments, or the whole .TH line,
doesn't reveal any problems either.


ischwarze@isnote $ cat     
.ab help2man is required to generate this page
.TH TH-BADBEFORE 1 "November 19, 2011"
TH-badbefore \- unknown macro before .TH
Some text.
ischwarze@isnote $ cat                                             
.TH TH-BADAFTER 1 "November 19, 2011"
.ab help2man is required to generate this page
TH-badafter \- unknown macro after .TH
Some text.
ischwarze@isnote $ mandoc > /dev/null && echo ok                  
ischwarze@isnote $ mandoc > /dev/null && echo ok  
ischwarze@isnote $ /usr/local/bin/nroff -mandoc -Tascii -c        
help2man is required to generate this page
ischwarze@isnote $ /usr/local/bin/nroff -mandoc -Tascii -c  
TH-BADAFTER(1)                                                  TH-BADAFTER(1)
help2man is required to generate this page
 To unsubscribe send an email to

  reply	other threads:[~2011-11-20 12:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2011-11-19 14:19 ` Ingo Schwarze
2011-11-20  4:25   ` Joerg Sonnenberger
2011-11-20  4:26     ` Joerg Sonnenberger
2011-11-20 12:27       ` Ingo Schwarze [this message]
2011-11-20 19:17         ` Joerg Sonnenberger
2011-12-03 21:41           ` Ingo Schwarze
2011-12-03 22:47             ` Joerg Sonnenberger
2011-12-03 23:50               ` Ingo Schwarze
2011-12-04  0:15                 ` Joerg Sonnenberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).