From: "Ulrich Spörlein" <uqs@spoerlein.net>
To: tech@mdocml.bsd.lv
Subject: [patch] avoid possible null pointer dereference
Date: Fri, 17 May 2013 03:37:39 +0200 [thread overview]
Message-ID: <20130517013739.GZ2055@acme.spoerlein.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
And the last one,
termp_xx_pre() will call term_word() with NULL when the switch case
falls through to the default case. There are several ways to avoid the
segfault, not sure this is the best one.
This is Coverity Scan CID 976115.
Cheers,
Uli
[-- Attachment #2: mdoc_term.diff --]
[-- Type: text/x-diff, Size: 430 bytes --]
Index: mdoc_term.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/mdoc_term.c,v
retrieving revision 1.245
diff -u -p -r1.245 mdoc_term.c
--- mdoc_term.c 17 Nov 2012 00:26:33 -0000 1.245
+++ mdoc_term.c 17 May 2013 01:32:03 -0000
@@ -1756,7 +1756,7 @@ termp_xx_pre(DECL_ARGS)
pp = "UNIX";
break;
default:
- break;
+ return(0);
}
term_word(p, pp);
next reply other threads:[~2013-05-17 1:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 1:37 Ulrich Spörlein [this message]
2013-05-18 17:54 ` Ingo Schwarze
2013-05-18 19:26 ` Ulrich Spörlein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517013739.GZ2055@acme.spoerlein.net \
--to=uqs@spoerlein.net \
--cc=tech@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).