Re: [patch] avoid possible null pointer dereference

["Ulrich Spörlein" <uqs@spoerlein.net>]

On Sat, 2013-05-18 at 19:54:35 +0200, Ingo Schwarze wrote:
> Hi Ulrich,
> 
> Ulrich Spörlein wrote on Fri, May 17, 2013 at 03:37:39AM +0200:
> 
> > termp_xx_pre() will call term_word() with NULL when the switch case
> > falls through to the default case.
> 
> Actually, that cannot happen because termp_xx_pre() will not be called
> for macros it is not intended to handle.
> 
> Still, it's arguably a cosmetical issue.  The code looks like the default
> case would be legitimate, which it is not.
> 
> > There are several ways to avoid the segfault, not sure this is the
> > best one.
> 
> No, it isn't, because that merely substitutes one uncontrolled failure
> mode by another one that's arguably even harder to debug, should it
> ever occur (after incorrect code changes elsewhere).
> 
> Instead, i committed a change to bsd.lv and openbsd.org using abort(3).

Thanks! I figured that it was not the best fix, but I don't know the API
"contracts" within mdocml.

There are a couple more issues that Coverity Scan thinks exists, but I
need to understand those better first.

Cheers,
Uli
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv