From: Ingo Schwarze <schwarze@usta.de>
To: Christian Neukirchen <chneukirchen@gmail.com>
Cc: tech@mdocml.bsd.lv
Subject: Re: mdocml fix for .PD
Date: Fri, 20 Mar 2015 17:35:34 +0100 [thread overview]
Message-ID: <20150320163534.GD27243@athene.usta.de> (raw)
In-Reply-To: <87zj786jxn.fsf@gmail.com>
Hi Christian,
Christian Neukirchen wrote on Fri, Mar 20, 2015 at 11:29:40AM +0100:
> I'm not exactly sure about the semantics of .PD, but applying the
> following
That patch is clearly wrong. For example, it breaks the following
OpenBSD regression test:
/usr/src/regress/usr.bin/mandoc/man/PD/nextline.in
Basically, it breaks anything that contains .PD after .TP or
.TP after .SH or .SS without arguments, that is, .TP after the block
macros that can have next-line head scope. The .PD macro is _not_
supposed to break block scope.
> affects 29 of 12419 manpages on my system, and in each case
> the new version looks as it's meant to be. It now renders like
> Groff 1.22.3 and Plan9 nroff.
>
> In particular this fixes:
>
> cscope.1 gawk.1 ksh.1 qrencode.1 tcsh.1 xargs.1 zip.1 zipcloak.1 zsh.1
> zshall.1 zshbuiltins.1 zshcalsys.1 zshcompctl.1 zshcompsys.1
> zshcompwid.1 zshcontrib.1 zshexpn.1 zshmisc.1 zshmodules.1
> zshoptions.1 zshparam.1 zshroadmap.1 zshtcpsys.1 zshzftpsys.1 zshzle.1
> elf.5 nsswitch.conf.5 nmh.7 chcpu.8
I'm not sure which system you are talking about - some Linux?
Is the problem with these pages still present in mandoc -HEAD,
or is it fixed after my recent commit? Please make sure you
have man_macro.c rev. 1.100 from mdocml.bsd.lv or man_macro.c
rev. 1.62 from OpenBSD when retesting.
Thanks,
Ingo
> --- man_macro.c 2015-03-13 13:38:38.000000000 +0100
> +++ man_macro.c 2015-03-19 23:20:11.786601197 +0100
> @@ -79,7 +79,7 @@
> { blk_exp, MAN_BSCOPE | MAN_EXPLICIT }, /* RS */
> { in_line_eoln, 0 }, /* DT */
> { in_line_eoln, 0 }, /* UC */
> - { in_line_eoln, 0 }, /* PD */
> + { in_line_eoln, MAN_BSCOPE }, /* PD */
> { in_line_eoln, 0 }, /* AT */
> { in_line_eoln, 0 }, /* in */
> { in_line_eoln, 0 }, /* ft */
--
To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv
next prev parent reply other threads:[~2015-03-20 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 10:29 Christian Neukirchen
2015-03-20 16:35 ` Ingo Schwarze [this message]
2015-03-20 16:45 ` Christian Neukirchen
-- strict thread matches above, loose matches on Subject: below --
2015-03-20 10:29 Christian Neukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320163534.GD27243@athene.usta.de \
--to=schwarze@usta.de \
--cc=chneukirchen@gmail.com \
--cc=tech@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).