Re: Parsing errors, output regressions with new XML parser

[Ingo Schwarze <schwarze@usta.de>]

Hi Stephen,

Stephen Gregoratto wrote on Sat, Mar 30, 2019 at 11:19:19AM +1100:

>   Another regression is that closing delimiters are put on separate 
>   lines. This leads to SEE ALSO sections like this[2] being formatted 
> [2] https://gitlab.com/esr/doclifter/blob/master/doclifter.xml#L988
>   like so:
> 
>   .Sh \&SEE ALSO
>   .Xr man 7
>   ,
>   .Xr mdoc 7
>   ,
>   .Xr ms 7
>   ,
>   .Xr me 7
>   ,
>   .Xr mm 7
>   ,
>   .Xr mwww 7
>   ,
>   .Xr troff 1
>   \&.

That was very easy to fix, see the commit below.
Looks like i broke that in the big rev. 1.68.

>   I noticed in a previous email you've begun working on a regression 
>   test suite of sorts. I could probably submit a couple examples of my 
>   own so these errors don't crop up again.

Sure, that would be welcome!
Maybe i should make the suite publicly available soon,
even though it is not portable yet.

Yours,
  Ingo


Log Message:
-----------
handle trailing delimiters after <citerefentry>/.Xr;
bug reported by Stephen Gregoratto <dev at sgregoratto dot me>

Modified Files:
--------------
    docbook2mdoc:
        docbook2mdoc.c

Revision Data
-------------
Index: docbook2mdoc.c
===================================================================
RCS file: /home/cvs/mdocml/docbook2mdoc/docbook2mdoc.c,v
retrieving revision 1.80
retrieving revision 1.81
diff -Ldocbook2mdoc.c -Ldocbook2mdoc.c -u -p -r1.80 -r1.81
--- docbook2mdoc.c
+++ docbook2mdoc.c
@@ -172,7 +172,6 @@ pnode_printciterefentry(struct format *p
 		macro_addarg(p, "1", ARG_SPACE);
 	else
 		macro_addnode(p, manvol, ARG_SPACE | ARG_SINGLE);
-	macro_close(p);
 	pnode_unlinksub(pn);
 }
 
--
 To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv