tech@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: Ingo Schwarze <schwarze@usta.de>
To: Stephen Gregoratto <dev@sgregoratto.me>
Cc: tech@mandoc.bsd.lv
Subject: Re: Parsing errors, output regressions with new XML parser
Date: Tue, 2 Apr 2019 19:20:37 +0200	[thread overview]
Message-ID: <20190402172037.GG6369@athene.usta.de> (raw)
In-Reply-To: <20190330001919.rrbc2xxrx47upalg@BlackBox>

Hi Stephen,

Stephen Gregoratto wrote on Sat, Mar 30, 2019 at 11:19:19AM +1100:

>   Another regression is that closing delimiters are put on separate 
>   lines. This leads to SEE ALSO sections like this[2] being formatted 
> [2] https://gitlab.com/esr/doclifter/blob/master/doclifter.xml#L988
>   like so:
> 
>   .Sh \&SEE ALSO
>   .Xr man 7
>   ,
>   .Xr mdoc 7
>   ,
>   .Xr ms 7
>   ,
>   .Xr me 7
>   ,
>   .Xr mm 7
>   ,
>   .Xr mwww 7
>   ,
>   .Xr troff 1
>   \&.

That was very easy to fix, see the commit below.
Looks like i broke that in the big rev. 1.68.

>   I noticed in a previous email you've begun working on a regression 
>   test suite of sorts. I could probably submit a couple examples of my 
>   own so these errors don't crop up again.

Sure, that would be welcome!
Maybe i should make the suite publicly available soon,
even though it is not portable yet.

Yours,
  Ingo


Log Message:
-----------
handle trailing delimiters after <citerefentry>/.Xr;
bug reported by Stephen Gregoratto <dev at sgregoratto dot me>

Modified Files:
--------------
    docbook2mdoc:
        docbook2mdoc.c

Revision Data
-------------
Index: docbook2mdoc.c
===================================================================
RCS file: /home/cvs/mdocml/docbook2mdoc/docbook2mdoc.c,v
retrieving revision 1.80
retrieving revision 1.81
diff -Ldocbook2mdoc.c -Ldocbook2mdoc.c -u -p -r1.80 -r1.81
--- docbook2mdoc.c
+++ docbook2mdoc.c
@@ -172,7 +172,6 @@ pnode_printciterefentry(struct format *p
 		macro_addarg(p, "1", ARG_SPACE);
 	else
 		macro_addnode(p, manvol, ARG_SPACE | ARG_SINGLE);
-	macro_close(p);
 	pnode_unlinksub(pn);
 }
 
--
 To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv

  parent reply	other threads:[~2019-04-02 17:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-30  0:19 Stephen Gregoratto
2019-04-02 13:16 ` Ingo Schwarze
2019-04-02 16:02 ` Ingo Schwarze
2019-04-02 16:50 ` Ingo Schwarze
2019-04-02 17:20 ` Ingo Schwarze [this message]
2019-04-02 17:48 ` Ingo Schwarze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190402172037.GG6369@athene.usta.de \
    --to=schwarze@usta.de \
    --cc=dev@sgregoratto.me \
    --cc=tech@mandoc.bsd.lv \
    --subject='Re: Parsing errors, output regressions with new XML parser' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).