Re: [PATCH] implement .Bk

[Kristaps Dzonsons <kristaps@bsd.lv>]

> yesterday night, i arrived at Edmonton for the c2k10, the OpenBSD
> yearly general hackathon.  I plan to spend this week on mandoc.
> 
> Here is the first patch i hacked up on the plane,
> implementing proper .Bk support.
> It is based on OpenBSD-current and can probably go in more or less
> as it is after merging bsd.lv HEAD into OpenBSD.

I like it with one nit noted in-line.  Also, can you document this in
mdoc.7?

Other than that, ok kristaps.

>  	if ( ! (TERMP_NOSPACE & p->flags)) {
> -		bufferc(p, ' ');
> -		if (TERMP_SENTENCE & p->flags)
> +		if (TERMP_KEEP & p->flags)
> +			bufferc(p, ASCII_NBRSP);
> +		else {
> +			if (TERMP_PREKEEP & p->flags)
> +				p->flags |= TERMP_KEEP;
>  			bufferc(p, ' ');
> +			if (TERMP_SENTENCE & p->flags)
> +				bufferc(p, ' ');
> +		}

In general, I try to have the "else" not have braces---most of the code
is structured as such.  Can you flip this to

  if ( ! (TERMP_KEEP & p->flags)) {
     multi-line
  } else
     buffer(p, ASCII_NBRSP);

I'm pretty dumb in this regard: seeing the else-brace without the
if-brace just plain confuses me.

Good work!

Kristaps

--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv