From: Ingo Schwarze <schwarze@usta.de>
To: tech@mdocml.bsd.lv
Subject: Re: [PATCH] implement .Bk
Date: Sat, 26 Jun 2010 15:53:19 +0200 [thread overview]
Message-ID: <20100626135319.GD22002@iris.usta.de> (raw)
In-Reply-To: <4C2606A4.8050203@bsd.lv>
Hi Kristaps,
> I like it with one nit noted in-line.
Good, thanks for looking!
> Also, can you document this in mdoc.7?
Sure.
> In general, I try to have the "else" not have braces---most of the code
> is structured as such. Can you flip this to
>
> if ( ! (TERMP_KEEP & p->flags)) {
> multi-line
> } else
> buffer(p, ASCII_NBRSP);
Yes, no problem, consistent style is helpful.
Myself, i do not really like
unless( condition ){
do something;
} else {
do something else;
}
in Perl, but perhaps "if (!) else" in C is not that bad.
Anyway, i will merge bsd.lv HEAD to OpenBSD, then apply your
points and commit to both trees.
Yours,
Ingo
--
To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv
prev parent reply other threads:[~2010-06-26 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-26 13:38 Ingo Schwarze
2010-06-26 13:54 ` Kristaps Dzonsons
2010-06-26 13:53 ` Ingo Schwarze [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100626135319.GD22002@iris.usta.de \
--to=schwarze@usta.de \
--cc=tech@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).