Re: mdocml: First, make `Pp' (next to `Sm') be allowed as the first element

Re: mdocml: First, make `Pp' (next to `Sm') be allowed as the first element

[Ingo Schwarze]

Hi Kristaps,

kristaps@mdocml.bsd.lv wrote on Wed, Dec 15, 2010 at 07:25:35PM -0500:

> Log Message:
> -----------
> First, make `Pp' (next to `Sm') be allowed as the first element of a
> `Bl' (before any `It' have been invoked).  Next, have the existence of
> either macro raise a warning, as it's technically not legal according to
> mdoc.7.

Hmm, i agree it is good that Pp does not throw FATAL at this point,
and it is good that Pp throws a WARNING here, but Sm is just fine.
How else would you switch to Sm mode just for the It?
That's a real use case!

Note that it looks like Lp is missing, too.

> Second, delete any `Pp' as the first element of a `Bl' (i.e., before an
> `It') ONLY when -compact has not been specified.  This matches with the
> latest version of groff.  This deletion happens prior to the above
> check, so double-warnings will not be issued.

That one sounds good.

Yours,
  Ingo
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

Re: mdocml: First, make `Pp' (next to `Sm') be allowed as the first element

[Ingo Schwarze]

Hi Kristaps,

replying to myself...

Ingo Schwarze wrote on Wed, Dec 22, 2010 at 12:33:38AM +0100:
> kristaps@mdocml.bsd.lv wrote on Wed, Dec 15, 2010 at 07:25:35PM -0500:

>> Log Message:
>> -----------
>> First, make `Pp' (next to `Sm') be allowed as the first element of a
>> `Bl' (before any `It' have been invoked).  Next, have the existence of
>> either macro raise a warning, as it's technically not legal according to
>> mdoc.7.

> Hmm, i agree it is good that Pp does not throw FATAL at this point,
> and it is good that Pp throws a WARNING here, but Sm is just fine.
[...]
> Note that it looks like Lp is missing, too.

Here is what i have done in OpenBSD to fix this.
Do you want that committed to bsd.lv as well?

Apart from that, and from .TS, we are now back in full sync.

Yours,
  Ingo


--- /usr/mdocml/mdoc_validate.c	Sat Dec 18 12:03:18 2010
+++ ./mdoc_validate.c	Tue Dec 21 16:57:31 2010
@@ -1570,12 +1574,14 @@ post_bl(POST_ARGS)
 
 	for (n = mdoc->last->child; n; n = n->next) {
 		switch (n->tok) {
-		case (MDOC_It):
-			continue;
-		case (MDOC_Sm):
+		case (MDOC_Lp):
 			/* FALLTHROUGH */
 		case (MDOC_Pp):
 			mdoc_nmsg(mdoc, n, MANDOCERR_CHILD);
+			/* FALLTHROUGH */
+		case (MDOC_It):
+			/* FALLTHROUGH */
+		case (MDOC_Sm):
 			continue;
 		default:
 			break;
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

Re: mdocml: First, make `Pp' (next to `Sm') be allowed as the first element

[Kristaps Dzonsons]

> Here is what i have done in OpenBSD to fix this.
> Do you want that committed to bsd.lv as well?
>
> Apart from that, and from .TS, we are now back in full sync.

I don't suppose I mind this, but for completeness, would like a note in 
mdoc.7 to the effect that `Sm' is allowed as a child of `Bl', as

  "Lists consist of items started by the It macro..."

is erroneous.  In general, I strongly want to avoid this sort of 
sometimes-it's-ok ambiguity that groff so generously bestows.  How about 
a note after the list types saying that this is allowed?

Thanks,

Kristaps
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv